1835238 - Ctrl + Shift + F keyboard shortcut does nothing after collapsing the sidebar a second time inside the debugger

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

• Filled on request: https://bugzilla.mozilla.org/show_bug.cgi?id=1833935#c16

Found in

• 114.0b9

Affected versions

• 115.0a1 (2023-05-25)
• 114.0b4

Tested platforms

• Affected platforms: Ubuntu 20.04, macOS 12, Windows 10x64
• Unaffected platforms: none

Steps to reproduce

1. Open the debugger on any page.
2. Collapse the sidebar if it’s visible.
3. Hit Ctrl+Shift+F (Cmd+Shift+F on OSX)
4. Collapse the sidebar.
5. Hit Ctrl+Shift+F (Cmd+Shift+F on OSX)

Expected result

• Left sidebar should open with the search UI visible.

Actual result

• Nothing happens.

Regression range

• I will search for one ASAP if it's possible because of bug 1833935.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1835238 - [devtools] Set active search to null when closing start panel. r=#devtools-reviewers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07517c0d8168
[devtools] Set active search to null when closing start panel. r=devtools-reviewers,ochameau.

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Removing the regression window wanted flag because I am unable to search for a regression range due to bug 1833935. Maybe this behavior happens after bug 1811000 or bug 1833935.

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/07517c0d8168

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 115.0a1 (20230531041723) on Windows 10x64, macOS 12 and Ubuntu 20.04. The left sidebar is opened with the search UI visible after collapsing the sidebar multiple times.