1835344 - Ensure no translations UI is shown on unsupported CPUs

Status: RESOLVED FIXED

(Firefox :: Translations, task, P3)

Description

[Marco Castelluccio [:marco]]

We won't get to bug 1811908 in time for the first release, so we need to make sure we are not showing any affordance to trigger translations on machines with unsupported CPUs.

Comment 1

[Greg Tatum [:gregtatum]]

The icon shouldn't show up since we test for support, but the "Translate page" option will most likely be in the app menu.

Comment 2

[Greg Tatum [:gregtatum]]

Ah, I forgot I implemented the following pref: browser.translations.simulateUnsupportedEngine

This would be good to check this bug.

Comment 3

[André Natal]

I've just tested this on the same VM I used to capture and display this error in the addon and can confirm that in the built-in version, the pageAction icon is not displayed, but the Translate page option in the hamburger menu is, which if clicked opens the translate popup. Still, a subsequent translation action fails, as expected.

Comment 4

[Greg Tatum [:gregtatum]]

We should probably remove it from the app menu when it's not supported then.

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 1835344 - Ensure translations panel respects engine support r=gregtatum!

Ensures that the translations panel cannot be opened if the
translations engine is not supported.

Depends on D179332

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61c56bf5a7ff
Ensure translations panel respects engine support r=gregtatum

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/61c56bf5a7ff