Closed Bug 1835381 Opened 3 years ago Closed 6 months ago

Allow searching/selecting for a folder when adding a new bookmark

Categories

(Firefox for Android :: Bookmarks, enhancement)

Product:
Firefox for Android
Component:
Bookmarks
Version:
Firefox 113
Platform:
All
Android
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
148 Branch
Tracking Flags:
Tracking Status
firefox148 --- fixed

People

(Reporter: apbytes, Assigned: fmasalha)

References

Details

(Whiteboard: [fxdroid][group1] )

User Story

Im not able to add my bookmark to a specific folder at the time I create it. I have to later go into the Bookmarks screen to categorize the folder.

Attachments

(1 file)

Bug 1835381 - Added search functionality to the select bookmarks screen.
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Android 13; Mobile; rv:109.0) Gecko/113.0 Firefox/113.0

Steps to reproduce:

  • Try to add a new bookmark
  • Click on folder to go to the view, where all bookmark folders are listed and a folder can be selected.

P.S. I would be willing to work on this, I've reported a similar search bug earlier with a PR but it was closed as complete, because there was a misunderstanding. The search functionality was added to the main bookmarks screen, but not to the bookmark folder list screen that is shown when adding a new bookmark. My issue and PR were related to the latter but due to some misunderstanding it was closed as a similar issue. I'd be happy to make a PR again.

Actual results:

There is no option to search for a folder, nor can it be sorted so user has to manually scroll and look for the folder they want.

Expected results:

Have an option to search for bookmark folder name to quickly get to that folder, when adding a new bookmark and selecting a folder for it.

Relevant pull request that I had made
https://github.com/mozilla-mobile/fenix/pull/21585

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true

Related to bug 1990332.

User Story: (updated)
Summary: Allow searching for a folder when adding a new bookmark → Allow searching/selecting for a folder when adding a new bookmark
Whiteboard: [fxdroid][group1]
Assignee: nobody → fmasalha
Pushed by fmasalha@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/baa3cf6e1213 https://hg.mozilla.org/integration/autoland/rev/b2e4862c157c Added search functionality to the select bookmarks screen. r=android-reviewers,android-l10n-reviewers,flod,matt-tighe

https://hg.mozilla.org/mozilla-central/rev/b2e4862c157c

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox148: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch

Faisal, could you consider nominating this for a release note? (Process info)

Flags: needinfo?(fmasalha)

Hey Donal, I think we are rethinking a lot around bookmarks due to performance and this will be disabled shortly i believe until we add some other code in the storage layer to support this feature with the upcoming changes.

Flags: needinfo?(fmasalha)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: