1835581 - In About Firefox dialog, no focus ring appears when press [Tab] key

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Alice0775 White]

Steps to reproduce:

1. Alt > Help > About Firefox
2. Press [Tab] key, and repeat step 2

Actual results:
No focus ring appears

Expected results
Focus ring should appear.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=850a5972994c7eb9705be5c598c7f304b2354927&tochange=1cdfa0b182b14ab3b9dbbb7d7b582f2a887a484e

Comment 1

[Alice0775 White]

I also reproduce on Ubuntu22.04.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:jules, since you are the author of the regressor, bug 1798404, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 4

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/080093fea70c

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1835581 - fix focusring in non-browser themed dialogs r?dao,jules

Comment 9

[Mark Striemer [:mstriemer]]

The dupes have the same fix, but should all be verified together.

Comment 10

[Gabi Cheta [:Gabi] Desktop QA]

I have reproduced this issue using Firefox 115.0a1 (2023.05.28) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 114.0 - build2 on Win 10 x64, macOS 12 and Ubuntu 22.04 x64.
Note: I verified the three other duplicate bugs: 1835583, 1835588, 1835590 the issue is fixed on Windows 10 and on Ubuntu 22, but on macOS the issue still reproduces.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50fa8ec134fc
fix focusring in non-browser themed dialogs r=dao,jules,desktop-theme-reviewers

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/50fa8ec134fc