1835622 - Perform length unit conversion in a single place

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Robert Longson [:longsonr]]

Unit conversion happens in

UserSpaceMetrics::ResolveAbsoluteUnit
SVGLength::GetUserUnitsPerUnit
SVGAnimatedLength::GetPixelsPerUnit

We should do all the conversion in one place and then if we want to add new units it's all much simpler.

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1835622 - Perform length unit conversion in a single place r=emilio

Comment 2

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=0f02f16f537f3b8d97de6535650759148adf1521

Comment 3

[Robert Longson [:longsonr]]

Attachment: Bug 1835622 - Perform length unit conversion in a single place r=emilio

Unit conversion happens in

UserSpaceMetrics::ResolveAbsoluteUnit
SVGLength::GetUserUnitsPerUnit
SVGAnimatedLength::GetPixelsPerUnit

If we do all the conversion in one place it's all much simpler if we want to add more units.

We also want to standardise naming so that we don't use UserUnits for some methods and Pixels for others so let's standardise on Pixels.

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=e4ee871a802d9eb134f7d368b2dd478aa46f7690

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e57010a0b90c
Perform length unit conversion in a single place r=emilio

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40383 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e57010a0b90c

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot