Closed Bug 1835649 Opened 10 months ago Closed 10 months ago

Avoid serializing the number of operations per sample for profiler counters that don't count operations

Categories

(Core :: Gecko Profiler, task)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

Profiler counters serialize both a count and a number of operations that were counted. As far as I know, only the memory counter uses the number of operations, and all the other counters serialize lots of zeros.

https://github.com/firefox-devtools/profiler/pull/4264 changed the front-end to make the 'number' field optional.

Example profile where only the memory counter has the "number" field: https://share.firefox.dev/3WHkIH6

I don't think this would reduce the gzipped size as an array of zeroes compresses very well, but it could save memory when the profile is not compressed (both during serialization within the Firefox processes, and within the profiler front-end).

Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c365694efc9c
Avoid serializing the number of operations per sample for profiler counters that don't count operations, r=canaltinova.
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.