Closed
Bug 1835665
Opened 2 years ago
Closed 2 years ago
Unify FocusDependencies with AC's DependenciesPlugin
Categories
(Focus :: General, task, P3)
Tracking
(firefox116 fixed)
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
Details
(Whiteboard: [fxdroid])
Attachments
(2 files)
As part of the monorepo project, we need to remove buildSrc directory which contains the FocusDependencies which is not reusable in a multi-project gradle setup. We have 2 options:
- Convert FocusDependencies into a plugin which is reusable via composite build. This will allow us to manage the dependencies separately and avoid refactoring the dependencies in Focus to the use the AC's DependenciesPlugin.
- Unify with AC's DependenciesPlugin so that we only have a single source of truth and maintain a synced list of dependencies and versions for all our apps.
After some discussions with RyanVM, there is a preference to move towards a single source of truth so that we don't have to duplicate work with managing 3 different files for maintaining dependencies.
Comment 1•2 years ago
|
||
| Assignee | ||
Comment 2•2 years ago
•
|
||
Notable version differences between Focus and AC:
- androidx.preference:preference-ktx AC 1.1.1 vs Focus 1.2.0
- com.squareup.leakcanary:leakcanary-android-core Focus leakcanary-android-core vs AC leakcanary-android
- com.squareup.okhttp3:mockwebserver
| Assignee | ||
Updated•2 years ago
|
Blocks: android-to-gecko-repos
| Assignee | ||
Updated•2 years ago
|
Whiteboard: [fxdroid]
Updated•2 years ago
|
Comment 3•2 years ago
|
||
Comment 4•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/9dbdca96787b487c81f77f10afc032f090dae66e
[main] Bug 1835665 - Unify FocusDependencies with AC's DependenciesPlugin
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox116:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
| Assignee | ||
Updated•2 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•