Closed Bug 183569 Opened 21 years ago Closed 20 years ago

every time I type a char in a message compose body, I see "no update for command: cmd_smiley" on the console

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.3beta

People

(Reporter: sspitzer, Assigned: cmanske)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Add a cmd_smiley case (in the right place)
564 bytes, patch
glazou
: review+
Details | Diff | Splinter Review 
every time I type a char in a message compose body, I see:

"no update for command: cmd_smiley" on the console
I know about this Composer problem.
Assignee: sspitzer → cmanske
Component: Composition → Editor: Composer
Product: MailNews → Browser
Target Milestone: --- → mozilla1.3beta
*** Bug 189200 has been marked as a duplicate of this bug. ***
Attached patch Add a cmd_smiley case (obsolete) — — Splinter Review 

    
  

        Attachment #138738 -
        Flags: superreview?(mscott)

        Attachment #138738 -
        Flags: review?(daniel)

    
    

    
  
The CVS blame for this diff for the fix for this points at bug 180303 but that
bug doesn't have a relevant patch... I guess it got checked in by mistake :-)
URL: http://bonsai.mozilla.org/cvsview2.cg...
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
Reopening,
http://lxr.mozilla.org/mozilla/source/editor/ui/composer/content/ComposerCommands.js#304
will still cause the console message to be dump'ed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
But nobody should be calling goUpdateCommandState('cmd_smiley') ...

    
    

    
  
Comment on attachment 138738 [details] [diff] [review]
Add a cmd_smiley case

OK, so after you insert a smiley Composer now thinks that smileys have state
(which they don't, it's just a hack) but you should not poke the state...

    
    

    
  


  
goUpdateCommandState('cmd_smiley') is still called

321	  if (commandNode.hasAttribute("state"))
322	    goUpdateCommandState(commandID);

because doStatefulCommand() adds the state attrib to the command.

412 function doStatefulCommand(commandID, newState)
413 {
414   var commandNode = document.getElementById(commandID);
415   if (commandNode)
416	  commandNode.setAttribute("state", newState);

But doStatefulCommand() already calls pokeMultiStateUI(), so the case should be
moved down a few lines.

    
  

        Attachment #138738 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 138983 [details] [diff] [review]
Add a cmd_smiley case (in the right place)

Looks good to me, but I'm rebuilding right now...

    
  

        Attachment #138738 -
        Flags: superreview?(mscott) → superreview+

    
    

    
  
Fix checked in.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED

    
  

        Attachment #138738 -
        Flags: review?(daniel)
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.