1835717 - [clang-trunk] Perma gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:585: TestNANTestingExprC.o] Error 1

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mh [at] glandium.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=417430087&repo=toolchains
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZrI0ejFTTOKaggsr4Mkopg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-05-29T21:42:58.661Z] 21:42:58     INFO -  /builds/worker/fetches/clang/bin/clang -isysroot /builds/worker/fetches/MacOSX13.3.sdk -mmacosx-version-min=10.12 -std=gnu99 --target=x86_64-apple-darwin -o TestNANTestingExprC.o -c  -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -I/builds/worker/checkouts/gecko/build/clang-plugin/tests -I/builds/worker/workspace/obj-build/build/clang-plugin/tests -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -include /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fno-sanitize-recover=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fsanitize-blacklist=/builds/worker/workspace/obj-build/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fcrash-diagnostics-dir=/builds/worker/artifacts -fPIC -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -fsyntax-only -Xclang -verify -ferror-limit=0 -Xclang -std=c11 -Wno-invalid-noreturn -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=tautological-type-limit-compare -Wno-range-loop-analysis -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-psabi -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/TestNANTestingExprC.o.pp   /builds/worker/checkouts/gecko/build/clang-plugin/tests/TestNANTestingExprC.c
[task 2023-05-29T21:42:58.662Z] 21:42:58     INFO -  error: 'warning' diagnostics seen but not expected:
[task 2023-05-29T21:42:58.662Z] 21:42:58     INFO -    Line 1: undefining builtin macro
[task 2023-05-29T21:42:58.662Z] 21:42:58     INFO -  1 error generated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1835717 - Disable _FORTIFY_SOURCE by setting it to 0 rather than undefining it.

Clang 17 made a change that made it an error to undefine _FORTIFY_SOURCE
on mac, because it's defined as a builtin when ASAN is enabled.
Defining it as 0 has the same effect of disabling it, but avoids the
error.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Toolchains' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d79f3579b56
Disable _FORTIFY_SOURCE by setting it to 0 rather than undefining it. r=tjr

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8d79f3579b56

Comment 5

[Intermittent Failures Robot]

1 failures in 3471 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• toolchains: 1

Platform and build breakdown:

• osx-cross: 1
  • asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1835717&startday=2023-05-29&endday=2023-06-04&tree=all