1835871 - Translations panel dialog element misses accessible name

Status: RESOLVED FIXED

(Firefox :: Translations, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

The translations panel element with role="alertdialog" includes an aria-labelledby attribute, but it is referencing an id that is not present in the DOM (translations-panel-main-header-label), thus there is no accessible name calculated for this dialog and screen readers only announce it as, for example by NVDA on Win, dialog.

The alertdialog could refer the translations-panel-header element that is an H1 that is present in the DOM and is an implied title of the panel.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nordzilla, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Greg Tatum [:gregtatum]]

Yeah, this is a regression from an earlier implementation. It doesn't seem that macOS VoiceOver does anything with this label. We should be able to write a test for it though.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1835871 - Fix the aria-labelledby attribute for the translations panel; r?nordzilla!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f347e97abf3
Fix the aria-labelledby attribute for the translations panel; r=nordzilla

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2f347e97abf3