Closed Bug 1835926 Opened 6 months ago Closed 6 months ago

Allow DLL blocklist to have combinations of flags


(Core :: DLL Services, enhancement, P3)




116 Branch
Tracking Status
firefox115 --- fixed
firefox116 --- fixed


(Reporter: gstoll, Assigned: gstoll)




(2 files)

Flags are used to restrict DLL blocklist entries to only certain versions of Windows or only certain processes. There's a comment in WindowsDllBlocklistInfo.h saying "These flags cannot be combined." and indeed, attempting to do so leads to a compilation error.

I'm not sure whether just fixing the compilation error would be enough to make this work.

This would have been nice to have for bug 1833793.

Severity: -- → S3
Priority: -- → P3
See Also: → 1826400

Ran into this again for bug 1826400, so I'm going to work on this now.

Assignee: nobody → gstoll
Pushed by
allow multiple blocklist flags r=gsvelto
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Blocks: 1826400
See Also: 1826400

Uplift Approval Request

  • Steps to reproduce for manual QE testing: n/a
  • Explanation of risk level: just changes how we generate code for blocklist
  • Code covered by automated testing: no
  • Risk associated with taking this patch: low
  • Needs manual QE test: no
  • Fix verified in Nightly: yes
  • User impact if declined: won't be able to uplift bug 1826400
  • Is Android affected?: no
  • String changes made/needed: no

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Greg, I'll let you request esr uplift on this one?

Flags: needinfo?(gstoll)

This is already in 115, so it will make it into the new ESR, and we decided we didn't want bug 1826400 in the previous ESR, so I don't think we need to do anything.

Flags: needinfo?(gstoll)
You need to log in before you can comment on or make changes to this bug.