1835943 - Incorrect CalledProcessError construction in mozversioncontrol

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them) (inactive until 2025-11-14)]

Error running mach:

    ['try', 'perf', '--rebuild', '10']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file try`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: CalledProcessError.__init__() missing 1 required positional argument: 'cmd'

  File "C:\Users\sasch\Documents\GitHub\gecko-dev\tools\tryselect\mach_commands.py", line 528, in try_perf
    return run(command_context, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\sasch\Documents\GitHub\gecko-dev\tools\tryselect\mach_commands.py", line 196, in run
    return mod.run(**kwargs)
           ^^^^^^^^^^^^^^^^^
  File "c:\users\sasch\documents\github\gecko-dev\tools\tryselect\selectors\perf.py", line 1304, in run
    revisions = PerfParser.run(
                ^^^^^^^^^^^^^^^
  File "c:\users\sasch\documents\github\gecko-dev\tools\tryselect\selectors\perf.py", line 1172, in run
    return PerfParser.perf_push_to_try(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\users\sasch\documents\github\gecko-dev\tools\tryselect\selectors\perf.py", line 1068, in perf_push_to_try
    push_to_try(
  File "c:\users\sasch\documents\github\gecko-dev\tools\tryselect\push.py", line 228, in push_to_try
    vcs.push_to_try(commit_message, allow_log_capture=allow_log_capture)
  File "c:\users\sasch\documents\github\gecko-dev\python\mozversioncontrol\mozversioncontrol\__init__.py", line 736, in push_to_try
    self._push_to_try_with_log_capture(
  File "c:\users\sasch\documents\github\gecko-dev\python\mozversioncontrol\mozversioncontrol\__init__.py", line 313, in _push_to_try_with_log_capture
    raise subprocess.CalledProcessError("Failed to push-to-try")
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Sentry event ID: 60f5249c70ba4a218186bf823d04ca11

The error situation is probably temporary but the call for the error constructor still looks incorrect.

Comment 1

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1835943 - Properly construct CallerProcessError in `_push_to_try_with_log_capture` r?#build

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eebce79aa786
Properly construct CallerProcessError in `_push_to_try_with_log_capture` r=ahal

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eebce79aa786