Fix tests that would break with dom.security.https_first enabled
Categories
(Core :: DOM: Security, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: maltejur, Assigned: maltejur)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [domsecurity-active])
Attachments
(24 files, 1 obsolete file)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
| Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
| Assignee | ||
Comment 2•2 years ago
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 6•2 years ago
|
||
| Assignee | ||
Comment 7•2 years ago
|
||
| Assignee | ||
Comment 8•2 years ago
|
||
| Assignee | ||
Comment 9•2 years ago
|
||
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
| bugherder | ||
Comment 14•2 years ago
|
||
Comment 15•2 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 16•2 years ago
|
||
| Assignee | ||
Comment 17•2 years ago
|
||
Comment 18•2 years ago
|
||
Comment 19•2 years ago
|
||
Comment 20•2 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 21•2 years ago
|
||
| Assignee | ||
Comment 22•2 years ago
|
||
| Assignee | ||
Comment 23•2 years ago
|
||
| Assignee | ||
Comment 24•2 years ago
|
||
| Assignee | ||
Comment 25•2 years ago
|
||
| Assignee | ||
Comment 26•2 years ago
|
||
Comment 27•2 years ago
|
||
Comment 28•2 years ago
|
||
Comment 29•2 years ago
|
||
Comment 30•2 years ago
|
||
Comment 31•2 years ago
|
||
Comment 32•2 years ago
|
||
Comment 33•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ced2f2b9cb19
https://hg.mozilla.org/mozilla-central/rev/f5b6320fea38
https://hg.mozilla.org/mozilla-central/rev/6981d5aa32b2
https://hg.mozilla.org/mozilla-central/rev/9f2d21642ba1
https://hg.mozilla.org/mozilla-central/rev/a1509016de49
https://hg.mozilla.org/mozilla-central/rev/35480813b599
Updated•2 years ago
|
Comment 34•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:mjurgens, maybe it's time to close this bug?
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 35•2 years ago
|
||
This still needs to be done in order for HTTPS-First to be enabled in Release in the future.
| Assignee | ||
Comment 36•1 year ago
|
||
Updated•1 year ago
|
| Assignee | ||
Comment 37•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 38•1 year ago
|
||
Comment 39•1 year ago
|
||
Backed out for causing bc failures related to networking.
[task 2024-03-21T13:22:09.204Z] 13:22:09 INFO - GECKO(11882) | [Child 12056: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7fb5c206c800) [pid = 12056] [serial = 5] [outer = 7fb5c373a200]
[task 2024-03-21T13:22:09.313Z] 13:22:09 INFO - GECKO(11882) | FATAL ERROR: Non-local network connections are disabled and a connection attempt to trackertest.org (3.139.180.21) was made.
[task 2024-03-21T13:22:09.314Z] 13:22:09 INFO - GECKO(11882) | You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
[task 2024-03-21T13:22:09.324Z] 13:22:09 INFO - GECKO(11882) | Hit MOZ_CRASH(Attempting to connect to non-local address! opener is [unknown], uri is [https://trackertest.org/browser/toolkit/components/processtools/tests/browser/dummy.html]) at /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:7326
[task 2024-03-21T13:22:09.335Z] 13:22:09 INFO - Initializing stack-fixing for the first stack frame, this may take a while...
[task 2024-03-21T13:22:23.394Z] 13:22:23 INFO - GECKO(11882) | #01: mozilla::net::nsHttpChannel::OnStartRequest(nsIRequest*) [netwerk/protocol/http/nsHttpChannel.cpp:7319]
[task 2024-03-21T13:22:23.395Z] 13:22:23 INFO - GECKO(11882) | #02: nsInputStreamPump::OnStateStart() [netwerk/base/nsInputStreamPump.cpp:504]
[task 2024-03-21T13:22:23.396Z] 13:22:23 INFO - GECKO(11882) | #03: nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) [netwerk/base/nsInputStreamPump.cpp:0]
[task 2024-03-21T13:22:23.396Z] 13:22:23 INFO - GECKO(11882) | #04: {virtual override thunk({offset(-24)}, nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*))} [netwerk/base/nsInputStreamPump.cpp:0]
[task 2024-03-21T13:22:23.398Z] 13:22:23 INFO - GECKO(11882) | #05: NS_NewCancelableRunnableFunction<CallbackHolder::CallbackHolder(nsIAsyncInputStream*, nsIInputStreamCallback*, unsigned int, nsIEventTarget*)::{lambda()#1}>(char const*, CallbackHolder::CallbackHolder(nsIAsyncInputStream*, nsIInputStreamCallback*, unsigned int, nsIEventTarget*)::{lambda()#1}&&)::FuncCancelableRunnable::Run() [xpcom/threads/nsThreadUtils.h:639]
[task 2024-03-21T13:22:23.398Z] 13:22:23 INFO - GECKO(11882) | #06: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:579]
[task 2024-03-21T13:22:23.399Z] 13:22:23 INFO - GECKO(11882) | #07: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:905]
[task 2024-03-21T13:22:23.400Z] 13:22:23 INFO - GECKO(11882) | #08: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:0]
[task 2024-03-21T13:22:23.400Z] 13:22:23 INFO - GECKO(11882) | #09: mozilla::TaskController::ProcessPendingMTTask(bool) [xpcom/threads/TaskController.cpp:514]
[task 2024-03-21T13:22:23.401Z] 13:22:23 INFO - GECKO(11882) | #10: mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run() [xpcom/threads/nsThreadUtils.h:549]
[task 2024-03-21T13:22:23.404Z] 13:22:23 INFO - GECKO(11882) | #11: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1203]
[task 2024-03-21T13:22:23.404Z] 13:22:23 INFO - GECKO(11882) | #12: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:480]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #13: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:85]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #14: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:346]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #15: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:150]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #16: nsAppShell::Run() [widget/gtk/nsAppShell.cpp:470]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #17: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:297]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #18: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:5753]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #19: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5965]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #20: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:6022]
[task 2024-03-21T13:22:23.405Z] 13:22:23 INFO - GECKO(11882) | #21: ??? [/builds/worker/workspace/build/application/firefox/firefox + 0x3e48a]
[task 2024-03-21T13:22:23.406Z] 13:22:23 INFO - GECKO(11882) | #22: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x21b97]
[task 2024-03-21T13:22:23.407Z] 13:22:23 INFO - GECKO(11882) | #23: ??? [/builds/worker/workspace/build/application/firefox/firefox + 0x3dfc9]
[task 2024-03-21T13:22:23.407Z] 13:22:23 INFO - GECKO(11882) | #24: ??? (???:???)
[task 2024-03-21T13:22:23.408Z] 13:22:23 INFO - GECKO(11882) | ExceptionHandler::GenerateDump cloned child 12185
Comment 40•1 year ago
|
||
| Assignee | ||
Comment 41•1 year ago
|
||
cert9.db, key4.db and mochitest.client have been generated by ./mach python build/pgo/genpgocert.py,
as per https://firefox-source-docs.mozilla.org/build/buildsystem/test_certificates.html.
| Assignee | ||
Updated•1 year ago
|
Comment 42•1 year ago
|
||
Comment 43•1 year ago
|
||
| bugherder | ||
Updated•1 year ago
|
Comment 44•1 year ago
|
||
Comment 45•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 46•1 year ago
|
||
Comment 47•1 year ago
|
||
Comment 48•1 year ago
|
||
Backed out for causing http related mochitest failures.
| Assignee | ||
Comment 49•1 year ago
|
||
I am not totally sure how this error was caused by my changes, but I will look into it.
Updated•1 year ago
|
Comment 50•1 year ago
|
||
Comment 51•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 52•1 year ago
|
||
Comment 53•1 year ago
|
||
Comment 54•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 55•1 year ago
|
||
This test would fail with HTTPS-First enabled because of the netmonitor reporting a negative latency. See Bug 1898241
Comment 56•1 year ago
|
||
Comment 57•1 year ago
|
||
| bugherder | ||
Comment 58•1 year ago
|
||
Comment 59•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 60•1 year ago
|
||
| Assignee | ||
Comment 61•1 year ago
|
||
This doesn't use the https_first_disabled annotation, as xpcshell tests don't
seem to support SpecialPowers.pushPrefEnv.
| Assignee | ||
Comment 62•1 year ago
|
||
Comment 63•1 year ago
|
||
Comment 64•1 year ago
•
|
||
Backed out (bug 1835983, bug 1719271) for causing multiple failures.
-
Failure log for bc failures on browser_contextmenu_share_macosx.js
-
Failure log for bc failures on browser_autocomplete_enter_race.js
To see all the failures that were caused by this and to get a better overview on how this affected the tests, please visit this link where I made a filter that shows all the failures classified with fix by commit after this backout.
Thank you!
Comment 65•1 year ago
|
||
| Assignee | ||
Comment 66•1 year ago
|
||
| Assignee | ||
Updated•1 year ago
|
Comment 67•1 year ago
|
||
| bugherder | ||
Comment 68•1 year ago
|
||
Comment 69•1 year ago
•
|
||
Backed out for causing mochitests failures.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_webrequest_worker.html | Should be expecting a request for
Also these mochitests failures.
L.E. There are also these mochitests ( Failure Log ) and these build bustages ( Failure Log ).
| Assignee | ||
Updated•1 year ago
|
Comment 70•1 year ago
|
||
Comment 71•1 year ago
•
|
||
Backed out for causing mochitests failures in browser_crossGroupOpener.js.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | docshell/test/browser/browser_crossGroupOpener.js | Test timed out -
Please also check this failure.
| Assignee | ||
Updated•1 year ago
|
Comment 72•1 year ago
|
||
Comment 73•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 75•1 year ago
|
||
I was gonna wait until Bug 1904221 is fixed, but as that one is actually more of a regression, I think we can close this bug.
Updated•1 year ago
|
Updated•1 year ago
|
Description
•