Closed Bug 1835983 Opened 2 years ago Closed 1 year ago

Fix tests that would break with dom.security.https_first enabled

Categories

(Core :: DOM: Security, task, P2)

task

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: maltejur, Assigned: maltejur)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(24 files, 1 obsolete file)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
Assignee: nobody → mjurgens
Status: NEW → ASSIGNED
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2317c21d7aeb Update browser/components/newtab/test/browser/browser_topsites_annotation.js to work with https-first enabled r=freddyb
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f65206d7f87a Update browser/components/sessionstore/test/browser_userTyped_restored_after_discard.js to work with https-first enabled r=freddyb
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [domsecurity-active]
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e503ea3e8643 Update browser/components/extensions/test/browser/browser_ext_webRequest_error_after_stopped_or_closed.js to work with https-first enabled r=freddyb,extension-reviewers,robwu
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef632cc47859 Update browser/components/originattributes/test/browser/browser_favicon_userContextId.js to work with https-first enabled r=freddyb
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ec2a2324562 Update browser/components/places/tests/browser/browser_bug485100-change-case-loses-tag.js to work with https-first enabled r=freddyb
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/459f7096c608 Update browser/components/urlbar/tests/browser/browser_urlbar_annotation.js to work with https-first enabled r=freddyb,mak
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/808527558110 Rework dom/websocket/tests/test_websocket_mixed_content_opener.html to work with https-first enabled r=freddyb
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91af44129253 Update accessible/tests/browser/e10s/browser_caching_document_props.js to work with https-first enabled r=freddyb
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ced2f2b9cb19 Update browser/components/extensions/test/browser/browser_ext_tabs_move_* to work with https-first enabled r=ckerschb,extension-reviewers,robwu
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5b6320fea38 Update dom/tests/browser/browser_localStorage_snapshotting.js to work with https-first enabled r=ckerschb
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6981d5aa32b2 Update netwerk/cookie/test/browser/browser_cookie_insecure_overwrites_secure.js to work with https-first enabled r=ckerschb,cookie-reviewers,edgul
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f2d21642ba1 Update netwerk/test/browser/browser_103_telemetry.js to work with https-first enabled r=necko-reviewers,kershaw
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1509016de49 Update toolkit/components/places/tests/browser/previews/browser_thumbnails.js to work with https-first enabled r=ckerschb
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35480813b599 Update dom/security/test/general/browser_same_site_cookies_bug1748693.js to work with https-first enabled r=ckerschb
Regressions: 1847590
Regressions: 1847591

The leave-open keyword is there and there is no activity for 6 months.
:mjurgens, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Flags: needinfo?(mjurgens)

This still needs to be done in order for HTTPS-First to be enabled in Release in the future.

Flags: needinfo?(mjurgens)
Blocks: 1719271
Attachment #9391008 - Attachment description: Bug 1835983: Update dom/base/test/fullscreen to work with https-first enabled r?freddyb → Bug 1835983 - Update tests in dom/base/test/fullscreen/ to work with https-first enabled r?freddyb
Attachment #9391008 - Attachment description: Bug 1835983 - Update tests in dom/base/test/fullscreen/ to work with https-first enabled r?freddyb → WIP: Bug 1835983 - Update tests in dom/base/test/fullscreen/ to work with https-first enabled r?freddyb
Attachment #9391008 - Attachment description: WIP: Bug 1835983 - Update tests in dom/base/test/fullscreen/ to work with https-first enabled r?freddyb → Bug 1835983 - Update tests in dom/base/test/fullscreen/ to work with https-first enabled r?freddyb
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d0a582672e6 Update tests in toolkit/components/ to work with https-first enabled r=freddyb

Backed out for causing bc failures related to networking.

[task 2024-03-21T13:22:09.204Z] 13:22:09     INFO - GECKO(11882) | [Child 12056: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7fb5c206c800) [pid = 12056] [serial = 5] [outer = 7fb5c373a200]
[task 2024-03-21T13:22:09.313Z] 13:22:09     INFO - GECKO(11882) | FATAL ERROR: Non-local network connections are disabled and a connection attempt to trackertest.org (3.139.180.21) was made.
[task 2024-03-21T13:22:09.314Z] 13:22:09     INFO - GECKO(11882) | You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
[task 2024-03-21T13:22:09.324Z] 13:22:09     INFO - GECKO(11882) | Hit MOZ_CRASH(Attempting to connect to non-local address! opener is [unknown], uri is [https://trackertest.org/browser/toolkit/components/processtools/tests/browser/dummy.html]) at /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:7326
[task 2024-03-21T13:22:09.335Z] 13:22:09     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2024-03-21T13:22:23.394Z] 13:22:23     INFO - GECKO(11882) | #01: mozilla::net::nsHttpChannel::OnStartRequest(nsIRequest*) [netwerk/protocol/http/nsHttpChannel.cpp:7319]
[task 2024-03-21T13:22:23.395Z] 13:22:23     INFO - GECKO(11882) | #02: nsInputStreamPump::OnStateStart() [netwerk/base/nsInputStreamPump.cpp:504]
[task 2024-03-21T13:22:23.396Z] 13:22:23     INFO - GECKO(11882) | #03: nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) [netwerk/base/nsInputStreamPump.cpp:0]
[task 2024-03-21T13:22:23.396Z] 13:22:23     INFO - GECKO(11882) | #04: {virtual override thunk({offset(-24)}, nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*))} [netwerk/base/nsInputStreamPump.cpp:0]
[task 2024-03-21T13:22:23.398Z] 13:22:23     INFO - GECKO(11882) | #05: NS_NewCancelableRunnableFunction<CallbackHolder::CallbackHolder(nsIAsyncInputStream*, nsIInputStreamCallback*, unsigned int, nsIEventTarget*)::{lambda()#1}>(char const*, CallbackHolder::CallbackHolder(nsIAsyncInputStream*, nsIInputStreamCallback*, unsigned int, nsIEventTarget*)::{lambda()#1}&&)::FuncCancelableRunnable::Run() [xpcom/threads/nsThreadUtils.h:639]
[task 2024-03-21T13:22:23.398Z] 13:22:23     INFO - GECKO(11882) | #06: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:579]
[task 2024-03-21T13:22:23.399Z] 13:22:23     INFO - GECKO(11882) | #07: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:905]
[task 2024-03-21T13:22:23.400Z] 13:22:23     INFO - GECKO(11882) | #08: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:0]
[task 2024-03-21T13:22:23.400Z] 13:22:23     INFO - GECKO(11882) | #09: mozilla::TaskController::ProcessPendingMTTask(bool) [xpcom/threads/TaskController.cpp:514]
[task 2024-03-21T13:22:23.401Z] 13:22:23     INFO - GECKO(11882) | #10: mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run() [xpcom/threads/nsThreadUtils.h:549]
[task 2024-03-21T13:22:23.404Z] 13:22:23     INFO - GECKO(11882) | #11: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1203]
[task 2024-03-21T13:22:23.404Z] 13:22:23     INFO - GECKO(11882) | #12: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:480]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #13: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:85]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #14: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:346]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #15: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:150]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #16: nsAppShell::Run() [widget/gtk/nsAppShell.cpp:470]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #17: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:297]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #18: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:5753]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #19: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5965]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #20: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:6022]
[task 2024-03-21T13:22:23.405Z] 13:22:23     INFO - GECKO(11882) | #21: ??? [/builds/worker/workspace/build/application/firefox/firefox + 0x3e48a]
[task 2024-03-21T13:22:23.406Z] 13:22:23     INFO - GECKO(11882) | #22: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x21b97]
[task 2024-03-21T13:22:23.407Z] 13:22:23     INFO - GECKO(11882) | #23: ??? [/builds/worker/workspace/build/application/firefox/firefox + 0x3dfc9]
[task 2024-03-21T13:22:23.407Z] 13:22:23     INFO - GECKO(11882) | #24: ??? (???:???)
[task 2024-03-21T13:22:23.408Z] 13:22:23     INFO - GECKO(11882) | ExceptionHandler::GenerateDump cloned child 12185
Flags: needinfo?(mjurgens)

cert9.db, key4.db and mochitest.client have been generated by ./mach python build/pgo/genpgocert.py,
as per https://firefox-source-docs.mozilla.org/build/buildsystem/test_certificates.html.

Flags: needinfo?(mjurgens)
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/792fcb4ab1ab Update tests in dom/base/test/fullscreen/ to work with https-first enabled r=freddyb,simonf
Regressions: 1889601
Attachment #9392708 - Attachment description: WIP: Bug 1835983 - Update tests in toolkit/components/extensions/ that would break with https-first → Bug 1835983 - Update tests in toolkit/components/extensions/ that would break with https-first
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/155636b6a8fc Update tests in toolkit/components/extensions/ that would break with https-first r=extension-reviewers,zombie
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/057e5bd486b4 Make https://trackertest.org available to mochitest r=nss-reviewers,jschanck https://hg.mozilla.org/integration/autoland/rev/deb09f084bed Update tests in toolkit/components/ to work with https-first enabled r=freddyb

Backed out for causing http related mochitest failures.

Flags: needinfo?(mjurgens)

I am not totally sure how this error was caused by my changes, but I will look into it.

Flags: needinfo?(mjurgens)
Attachment #9393005 - Attachment is obsolete: true
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90061199e2d1 Update tests in toolkit/components/ to work with https-first enabled r=freddyb
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4eb99068362e Disable HTTPS-First explicitly in browser/components/urlbar/tests/browser/browser_urlbar_telemetry_autofill.js r=freddyb,mak

This test would fail with HTTPS-First enabled because of the netmonitor reporting a negative latency. See Bug 1898241

Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a9638e3ec48c Update tests in toolkit/components/passwordmgr/ to work with https-first enabled r=credential-management-reviewers,issammani
Regressions: 1898272
No longer regressions: 1898272
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e58ab1051fc8 Annotate devtools/client/netmonitor/test/browser_net_columns_time.js to disable HTTPS-First r=freddyb,devtools-reviewers,nchevobbe

This doesn't use the https_first_disabled annotation, as xpcshell tests don't
seem to support SpecialPowers.pushPrefEnv.

Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b8e7959184a Disable HTTPS-First explicitly in netwerk/test/browser/browser_bug968273.js r=freddyb https://hg.mozilla.org/integration/autoland/rev/c5eed965602e Annotate xpcshell tests failing with HTTPS-First r=freddyb,cookie-reviewers https://hg.mozilla.org/integration/autoland/rev/53a1814554bf Disable HTTPS-First in devtools/client/netmonitor/test/browser.toml r=freddyb,devtools-reviewers,jdescottes

Backed out (bug 1835983, bug 1719271) for causing multiple failures.

To see all the failures that were caused by this and to get a better overview on how this affected the tests, please visit this link where I made a filter that shows all the failures classified with fix by commit after this backout.
Thank you!

Flags: needinfo?(mjurgens)
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c7a7a294b2bf Disable HTTPS-First explicitly in netwerk/test/browser/browser_bug968273.js r=freddyb https://hg.mozilla.org/integration/autoland/rev/bf546a59c3af Annotate xpcshell tests failing with HTTPS-First r=freddyb,cookie-reviewers https://hg.mozilla.org/integration/autoland/rev/729db7523b86 Disable HTTPS-First in devtools/client/netmonitor/test/browser.toml r=freddyb,devtools-reviewers,jdescottes
Flags: needinfo?(mjurgens)
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/10010b949e52 Fix remaining tests failing with HTTPS-First r=freddyb,extension-reviewers,anti-tracking-reviewers,android-reviewers,geckoview-reviewers,robwu

Backed out for causing mochitests failures.

Also these mochitests failures.

L.E. There are also these mochitests ( Failure Log ) and these build bustages ( Failure Log ).

Flags: needinfo?(mjurgens)
Flags: needinfo?(mjurgens)
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d79d15d3ad7c Fix remaining tests failing with HTTPS-First r=freddyb,extension-reviewers,anti-tracking-reviewers,android-reviewers,geckoview-reviewers,robwu

Backed out for causing mochitests failures in browser_crossGroupOpener.js.

Please also check this failure.

Flags: needinfo?(mjurgens)
Flags: needinfo?(mjurgens)
Pushed by mjurgens@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51ee3e13a9a1 Fix remaining tests failing with HTTPS-First r=freddyb,extension-reviewers,anti-tracking-reviewers,android-reviewers,geckoview-reviewers,robwu
Regressions: 1904221
See Also: → 1904266
See Also: → 1732862

Can this be closed now?

Flags: needinfo?(mjurgens)

I was gonna wait until Bug 1904221 is fixed, but as that one is actually more of a regression, I think we can close this bug.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Flags: needinfo?(mjurgens)
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
No longer regressions: 1847591
No longer regressions: 1847590
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: