3.5 - 1.94% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors + 7 more (Android, Linux, OSX, Windows) regression on Fri May 26 2023
Categories
(Core :: SVG, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox113 | --- | unaffected |
| firefox114 | --- | unaffected |
| firefox115 | --- | fixed |
People
(Reporter: afinder, Assigned: dholbert)
References
(Regression)
Details
(Keywords: perf-alert, regression)
Perfherder has detected a build_metrics performance regression from push 419be14a6b2616f347b660caaa4e6d1cc341e940. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 4% | compiler_metrics num_static_constructors | osx-cross | 107.25 -> 111.00 | |
| 3% | compiler_metrics num_static_constructors | osx-aarch64-shippable | aarch64 | 103.83 -> 107.00 |
| 3% | compiler_metrics num_static_constructors | osx-shippable | 103.83 -> 107.00 | |
| 3% | compiler_metrics num_static_constructors | osx-shippable | instrumented | 107.75 -> 111.00 |
| 3% | compiler_metrics num_static_constructors | android-5-0-x86_64 | 103.00 -> 106.00 | |
| 3% | compiler_metrics num_static_constructors | android-5-0-x86_64 | lite | 103.00 -> 106.00 |
| 3% | compiler_metrics num_static_constructors | windows2012-64 | 118.00 -> 121.00 | |
| 2% | compiler_metrics num_static_constructors | windows2012-32 | 125.00 -> 128.00 | |
| 2% | compiler_metrics num_static_constructors | linux64 | 155.00 -> 158.00 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.
For more information on performance sheriffing please see our FAQ.
|
Reporter | |
Comment 1•2 years ago
|
||
Hi Daniel! For the regressing commit, there seems to be 2 patches attached showing up in the job view. I logged the regression defect based on Bug 1835177 since that was the patch which looks like it could have caused the regression. Please let me know if the other patch (Bug 1604498) was the actual culprit. Thanks!
|
|
Reporter | |
Comment 2•2 years ago
|
||
(In reply to Alex Finder from comment #0)
Perfherder has detected a build_metrics performance regression from push 419be14a6b2616f347b660caaa4e6d1cc341e940. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
Ratio Test Platform Options Absolute values (old vs new) 4% compiler_metrics num_static_constructors osx-cross 107.25 -> 111.00 3% compiler_metrics num_static_constructors osx-aarch64-shippable aarch64 103.83 -> 107.00 3% compiler_metrics num_static_constructors osx-shippable 103.83 -> 107.00 3% compiler_metrics num_static_constructors osx-shippable instrumented 107.75 -> 111.00 3% compiler_metrics num_static_constructors android-5-0-x86_64 103.00 -> 106.00 3% compiler_metrics num_static_constructors android-5-0-x86_64 lite 103.00 -> 106.00 3% compiler_metrics num_static_constructors windows2012-64 118.00 -> 121.00 2% compiler_metrics num_static_constructors windows2012-32 125.00 -> 128.00 2% compiler_metrics num_static_constructors linux64 155.00 -> 158.00 Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.
For more information on performance sheriffing please see our FAQ.
== Change summary for alert #38473 (as of Fri, 26 May 2023 07:32:34 GMT) ==
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 3% | compiler_metrics num_static_constructors | android-5-0-x86 | 101.00 -> 104.00 | |
| 3% | compiler_metrics num_static_constructors | android-4-1-armv7 | 102.00 -> 105.00 | |
| 3% | compiler_metrics num_static_constructors | osx-nightlyasrelease | nightly-as-release | 102.83 -> 105.83 |
| 3% | compiler_metrics num_static_constructors | android-5-0-aarch64 | lite | 104.00 -> 107.00 |
| 3% | compiler_metrics num_static_constructors | win64-nightlyasrelease | nightly-as-release | 113.00 -> 116.00 |
| 3% | compiler_metrics num_static_constructors | windows2012-aarch64 | aarch64-no-eme | 114.00 -> 117.00 |
| 3% | compiler_metrics num_static_constructors | windows2012-aarch64 | aarch64 | 119.00 -> 122.00 |
| 2% | compiler_metrics num_static_constructors | windows2012-32-shippable | 121.00 -> 124.00 | |
| 2% | compiler_metrics num_static_constructors | windows2012-64-shippable | instrumented | 121.00 -> 124.00 |
| 2% | compiler_metrics num_static_constructors | windows2012-32-shippable | instrumented | 129.00 -> 132.00 |
| 2% | compiler_metrics num_static_constructors | linux64 | x11 | 148.00 -> 151.00 |
| 2% | compiler_metrics num_static_constructors | linux64-aarch64 | 150.00 -> 153.00 | |
| 2% | compiler_metrics num_static_constructors | linux64-nightlyasrelease | nightly-as-release | 150.00 -> 153.00 |
| 2% | compiler_metrics num_static_constructors | linux64-qr | valgrind | 155.00 -> 158.00 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38473
|
|
Reporter | |
Comment 3•2 years ago
|
||
(In reply to Alex Finder from comment #2)
(In reply to Alex Finder from comment #0)
Perfherder has detected a build_metrics performance regression from push 419be14a6b2616f347b660caaa4e6d1cc341e940. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
Ratio Test Platform Options Absolute values (old vs new) 4% compiler_metrics num_static_constructors osx-cross 107.25 -> 111.00 3% compiler_metrics num_static_constructors osx-aarch64-shippable aarch64 103.83 -> 107.00 3% compiler_metrics num_static_constructors osx-shippable 103.83 -> 107.00 3% compiler_metrics num_static_constructors osx-shippable instrumented 107.75 -> 111.00 3% compiler_metrics num_static_constructors android-5-0-x86_64 103.00 -> 106.00 3% compiler_metrics num_static_constructors android-5-0-x86_64 lite 103.00 -> 106.00 3% compiler_metrics num_static_constructors windows2012-64 118.00 -> 121.00 2% compiler_metrics num_static_constructors windows2012-32 125.00 -> 128.00 2% compiler_metrics num_static_constructors linux64 155.00 -> 158.00 Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.
For more information on performance sheriffing please see our FAQ.
== Change summary for alert #38473 (as of Fri, 26 May 2023 07:32:34 GMT) ==
Regressions:
Ratio Test Platform Options Absolute values (old vs new) 3% compiler_metrics num_static_constructors android-5-0-x86 101.00 -> 104.00 3% compiler_metrics num_static_constructors android-4-1-armv7 102.00 -> 105.00 3% compiler_metrics num_static_constructors osx-nightlyasrelease nightly-as-release 102.83 -> 105.83 3% compiler_metrics num_static_constructors android-5-0-aarch64 lite 104.00 -> 107.00 3% compiler_metrics num_static_constructors win64-nightlyasrelease nightly-as-release 113.00 -> 116.00 3% compiler_metrics num_static_constructors windows2012-aarch64 aarch64-no-eme 114.00 -> 117.00 3% compiler_metrics num_static_constructors windows2012-aarch64 aarch64 119.00 -> 122.00 2% compiler_metrics num_static_constructors windows2012-32-shippable 121.00 -> 124.00 2% compiler_metrics num_static_constructors windows2012-64-shippable instrumented 121.00 -> 124.00 2% compiler_metrics num_static_constructors windows2012-32-shippable instrumented 129.00 -> 132.00 2% compiler_metrics num_static_constructors linux64 x11 148.00 -> 151.00 2% compiler_metrics num_static_constructors linux64-aarch64 150.00 -> 153.00 2% compiler_metrics num_static_constructors linux64-nightlyasrelease nightly-as-release 150.00 -> 153.00 2% compiler_metrics num_static_constructors linux64-qr valgrind 155.00 -> 158.00 For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38473
== Change summary for alert #38474 (as of Fri, 26 May 2023 08:27:54 GMT) ==
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 3% | compiler_metrics num_static_constructors | android-5-0-aarch64 | 104.00 -> 107.00 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38474
|
||
Comment 4•2 years ago
|
||
Set release status flags based on info from the regressing bug 1835177
|
Assignee | |
Comment 5•2 years ago
|
||
(In reply to Alex Finder from comment #1)
I logged the regression defect based on Bug 1835177 since that was the patch which looks like it could have caused the regression.
Yup, it makes sense that that could've increased our static constructor count.
I should probably use StaticAutoPtr instead of UniquePtr there. Leaving needinfo open.
|
|
Assignee | |
Comment 6•2 years ago
|
||
I've requested in #sheriffs that the offending patch be backed out. I'll re-land later on today with a better patch that hopefully should avoid this.
|
|
Assignee | |
Comment 7•2 years ago
|
||
Fixed by backout in https://bugzilla.mozilla.org/show_bug.cgi?id=1835177#c4 .
|
||
Updated•2 years ago
|
Description
•