1836022 - Protection Panel (Lock icon in the taskbar) crashes Fenix on any IP address with Cookie Banner Reduction enabled

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Dennis Schubert [:denschub]]

Steps to reproduce

1. Ensure Cookie Banner Reduction is enabled
2. Open https://1.1.1.1 (or any IP that serves HTTP, for that matter)
3. Click the lock icon in the address bar

Expected behavior

Panel shows up

Actual behavior

The entire browser crashes.

Any additional information?

The crash is

java.lang.Exception: Unexpected error: [Exception... "Component returned failure code: 0x804b0051 (NS_ERROR_HOST_IS_IP_ADDRESS) [nsICookieBannerService.getDomainPref]" nsresult: "0x804b0051 (NS_ERROR_HOST_IS_IP_ADDRESS)" location: "JS frame :: resource://gre/modules/GeckoViewStorageController.sys.mjs :: onEvent :: line 263" data: no]

So that is this call to Services.cookieBanners.getDomainPref, which does not appreciate getting an IP instead of a domain.

On Desktop, the call is wrapped in a try/catch, with a comment that explains that this is precisely to handle IP addresses.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1836022 - catch NS_ERROR_HOST_IS_IP_ADDRESS when querying cookie banners exception (#2314)

Comment 2

[BMO Github Automation]

Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/d7cd6cf9582e2e464d95c60614757f2f05b244b4
[main] Bug 1836022 - catch NS_ERROR_HOST_IS_IP_ADDRESS when querying cookie banners exception

Comment 3

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly 116.0a1 build from 08.06.2023.
The described issue is no longer reproducible on the latest Nightly.
Devices used to verify:
Motorola Moto G9 plus (Android 11)
Samsung GalaxyZ Fold 4 (Android 13)

Comment 4

[Adina Petridean QA [:apetridean]]

Attachment: 1.1.1.1.JPEG

Comment 5

[Chris Peterson [:cpeterson]]

No need to uplift to 115.