Remote revisions are required for `mach try perf`
Categories
(Conduit :: Lando, task)
Tracking
(Not tracked)
People
(Reporter: sparky, Unassigned)
References
Details
With the proposed improvements to mach try in bug 1835958, the remote revision will no longer be output locally. This is an issue for us because because mach try perf parses the local hg logging to get the remote revision so that we can build a perfherder compare view link and provide it to the user locally. See here: https://searchfox.org/mozilla-central/source/tools/tryselect/selectors/perf.py#1315-1327
We'll need some way to get those two remote revisions so that we can continue to provide the compare view link at the end of the mach try perf run.
Due to the asynchronous nature of the submission it will not be technically possible to honour the current workflow of displaying a view link at the end of mach try perf command.
We'll chat about what other options we have here (such as an email from Lando with the information), as well as if this should block the rollout of this change.
|
||
Comment 2•1 year ago
|
||
(In reply to :glob ✱ from comment #1)
Due to the asynchronous nature of the submission it will not be technically possible to honour the current workflow of displaying a view link at the end of
mach try perfcommand.We'll chat about what other options we have here (such as an email from Lando with the information), as well as if this should block the rollout of this change.
Technically, we could add a --sync flag that will wait and poll Lando until the landing job is complete, and output back whatever we need from that. Just a possible idea.
(In reply to Zeid Zabaneh [:zeid] from comment #2)
Technically, we could add a
--syncflag that will wait and poll Lando until the landing job is complete, and output back whatever we need from that. Just a possible idea.
As the primary driver behind this work is to avoid long wait times during submission I don't think this is an approach we should take.
|
Reporter | |
Comment 4•1 year ago
|
||
Having an email sent to the user who pushed the two commits would work for us. It takes some time for the performance tests to run so they don't need to have the compare view link immediately.
|
|
Reporter | |
Comment 5•1 year ago
|
||
Something else that I forgot to mention is that we also use one of the remote revisions (base one) to cache past try runs: https://searchfox.org/mozilla-central/source/tools/tryselect/selectors/perf.py#893-919
This lets us prevent unnecessary CI usage when a base run already exists that can be used as a comparison point. It would be useful to have a way to get that base run revision on subsequent runs of mach-try-perf so we can continue this caching.
For the initial deliverable in the Try/Lando work we'll have a carve-out for mach try perf — it will continue to function as-is.
We'll circle around to helping improve mach try perf's performance at a later date.
Description
•