1836214 - Unable to configure CardDAV because new CardDAV Address book dialog doesn't resize after fetching available address books

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Peter]

Attachment: Troubleshooting data for this regression

+++ This bug was initially created as a clone of Bug #1744144 +++

STR

• New Address Book tab
• Select Add CardDav Address Book
• Fill up the fields and click continue

If multiple address books are available and listed, the dialog doesn't resize properly to accommodate the new content, resulting in the buttons being pushed outside the viewport area.

Comment 1

[Peter]

Bug #1744144 says it's fixed, I cannot comment the bug due to permissions, so I cloned into this bug, hope that's okay.
Just found that the box still is too smal when carddav provides more than ~2 address books.
The issue is not entirely "cannot create at all", because you can still use the tab key to "guess" where the "OK" button is to complete the dialogue.

Nevertheless, the box still doesn't adjust to the number of returned address books.

Comment 2

[Lukas.Wringer]

This is clearly a regression as it was fixed for 102. Now its back again with 115...

Comment 3

[Magnus Melin [:mkmelin]]

Bug 1821554 changed some things. But this is at least also partly a modern flexbox regression

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1836214 - Fix CardDAV Address book dialog resizing issues causing the available address books to push buttons out of view. r=#thunderbird-front-end-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/459a39ac9d9f
Fix CardDAV Address book dialog resizing issues causing the available address books to push buttons out of view. r=aleca

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9343702 [details]
Bug 1836214 - Fix CardDAV Address book dialog resizing issues causing the available address books to push buttons out of view. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta
Approved for esr115 assuming successful beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 116.0b7:
https://hg.mozilla.org/releases/comm-beta/rev/1204f346623a

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/c85a91d81a5a