183622 - Can't drop URL objects onto Mozilla

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[David Mediavilla]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; es-AR; rv:1.2.1) Gecko/20021201
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; es-AR; rv:1.2.1) Gecko/20021201

In Netscape 4.61 and earlier, dropping a URL object (WPUrl WPS class, I think)
onto the browser client area (and probably other places) opens that URL.
That doesn't work with Mozilla, everywhere I get the "no way" sign, which is a
pity since I prefer folders with URL objects rather than bookmark files.

Reproducible: Always

Steps to Reproduce:
1. Open Mozilla
2. Open a WPS folder with URL objects.
3. Drag the object.
4. Drop it onto anywhere in the Mozilla window.
5. ...
6. Profit! (No, just joking)
Actual Results:  
Nothing

Expected Results:  
Move the current tab to the URL contained into the URL object. If it is dropped
onte a hidden tab, it should bring that tab to the front perhaps.

The theme is Modern.
The Browser ID is seen by Bugzilla as es-AR, but I see the interface in English.
I haven't changed the interface language yet. I don't know if it has picked the
"es-AR" from the previus version (1.2 beta, I think), which had UABar or
prefbar. Maybe it was picked when I have tried to open Phoenix 0.4 besides Mozilla.
I use the WPS extension DragText 3.7. It can insert URL objects as text in
arbitrary programs, but not in Mozilla windows.

I think this is difficult to solve in XUL, but I do like URL objects. An
alternative would be dropping onto a program that through DDE sends the URL to
Mozilla, I'll have to check if NetscDDE in XWorkPlace can do that.

Comment 1

[Mike Kaply [:mkaply]]

Nice Southpark reference.

Yeah, we know about this one. I've just been putting it off.

I'll take it for now.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: First patch

OK, this is patch one.

It adds drag drop from the desktop (including stuff with spaces which was broke
in 1.3)

It also adds the ability to hold down the Ctrl key to make copies of web pages
and images locally.

Last thing to do is filename munging (http://www.yahoo.com ->
www_yahoo_com.html)

Comment 3

[Steve Wendt]

Why do we need filename munging?  Is this primarily to avoid incorrect handling
of extensions by the WPS?

Comment 4

[Mike Kaply [:mkaply]]

basically to work like 2.02.

What should the filename be when you drag http://www.yahoo.com/ to the desktop
to get the HTML?

Obviously, http://www.yahoo.com/page.html should be page.html.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Final fix

OK, final patch. Some of this is a little hackish but I did the best I could.

This makes drag drop work pretty cool.

Comment 6

[jhp (no longer active)]

Comment on attachment 118444 [details] [diff] [review]
Final fix

You are doing multiple NS_ConvertASCIItoUCS2 calls to put text into dragData. 
Instead, make dragData an nsCAutoString and just do one big
NS_ConvertASCIItoUCS2 at the end.  Otherwise, r=pedemont

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Final patch

last fix with Javier's stuff so that I can check it in from home.

Comment 8

[Mike Kaply [:mkaply]]

Fix checked in.