Closed Bug 1836285 Opened 2 years ago Closed 2 years ago

Background Tab-Kills increased on Nightly and Beta

Categories

(GeckoView :: General, defect, P1)

All
Android
defect

Tracking

(firefox113 unaffected, firefox114 fixed, firefox115 fixed)

RESOLVED FIXED
115 Branch
Tracking Status
firefox113 --- unaffected
firefox114 --- fixed
firefox115 --- fixed

People

(Reporter: kaya, Assigned: kaya)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

As seen from the graph of new tab-kills telemetry, the background tab-kills increased in Nightly and Beta for v114 train.

Severity: -- → S2
Keywords: regression
Priority: -- → P1
Regressed by: 1815015
Assignee: nobody → kkaya

Set release status flags based on info from the regressing bug 1815015

Pushed by kkaya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c870e0b631b Revert "Bug 1815015 - Set the activeness of the browser to false by default at the time of its creation. r=geckoview-reviewers,calu"
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch

The patch landed in nightly and beta is affected.
:kaya, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(kkaya)

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #5)

The patch landed in nightly and beta is affected.
:kaya, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Android Foundation team's engineering manager Bryan Clark confirms that we can uplift this change to 114.

Flags: needinfo?(kkaya)

Comment on attachment 9337064 [details]
Bug 1836285 - Revert "Bug 1815015 - Set the activeness of the browser to false by default at the time of its creation. r=#geckoview-reviewers"

Beta/Release Uplift Approval Request

  • User impact if declined: This patch, backs out a change that was introduced on April 27, 2023. The backed out change caused an increase in the number of background tab kills. As the current telemetry is not explaining what's happening, for now the change needed to be backed out. Soon, with an addition of new telemetries, the change will be reintroduced again.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch is a back out patch, there is no new code introduced, just reverting back to the old code.
  • String changes made/needed:
  • Is Android affected?: Yes
Attachment #9337064 - Flags: approval-mozilla-beta?

Comment on attachment 9337064 [details]
Bug 1836285 - Revert "Bug 1815015 - Set the activeness of the browser to false by default at the time of its creation. r=#geckoview-reviewers"

Fx115 is currently in Beta. Fx114 is currently in release.
Changing uplift request from beta to release

Attachment #9337064 - Flags: approval-mozilla-beta? → approval-mozilla-release?

Comment on attachment 9337064 [details]
Bug 1836285 - Revert "Bug 1815015 - Set the activeness of the browser to false by default at the time of its creation. r=#geckoview-reviewers"

Approved for 104.0.2 next week, thanks.

Attachment #9337064 - Flags: approval-mozilla-release? → approval-mozilla-release+

Soon, with an addition of new telemetries, the change will be reintroduced again.

Kaya, is there a bug to follow-up on this part?

Flags: needinfo?(kkaya)

yes, see Bug 1859846. One of my P2 items.

Flags: needinfo?(kkaya)
Blocks: 1859846
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: