1836301 - Port bug 1835119: Remove NSCAP_FEATURE_USE_BASE

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Martin Giger [:freaktechnik]]

The bustage fix (https://hg.mozilla.org/comm-central/rev/264eb072ba8f) broke moving/deleting

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1836301 - Clean-up a bit imap copy / moves, and use SameCOMIdentity to compare nsISupports pointers properly. r=freaktechnik

Some kind of inheritance chains, like this:

https://searchfox.org/comm-central/rev/c44029650a19b926a4b467b5ed76cac5c76a30ec/mailnews/base/src/nsMsgDBFolder.h#91-96

Have multiple nsISupports* representations. E.g.:

• nsSupportsWeakReference -> nsISupportsWeakReference -> nsISupports
• nsIMsgFolder -> nsISupports

When comparing two nsISupports pointers, the pointer value is not quite
relevant, the COM identity is.

Before https://hg.mozilla.org/comm-central/rev/264eb072ba8f, the
do_QueryInterface to nsISupport acted like the "get canonical supports
pointer", so the pointer comparison worked.

Instead, use SameCOMIdentity to check for equality.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90613f14b75a
Clean-up a bit imap copy / moves, and use SameCOMIdentity to compare nsISupports pointers properly. r=freaktechnik