1836447 - Move BookmarkNode extension functions to BookmarkNode class in AC concept-storage module

Status: VERIFIED FIXED

(Firefox for Android :: Bookmarks, task, P3)

Description

[Rahul Sainani [:rsainani]]

Currently there are two "extension" functions for BookmarkNode in fenix. BookmarkNode is a AC class and we should add the functionality there.

1. minus is an extension function
2. getBookmarkCount is a private function in HomeActivity. This can be simplified by moving both to BookmarkNode class.

Also add tests for getBookmarkCount.

This will also reduce the size of HomeActivity, which should ideally only contain the glue code.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1836447 - Make extension functions member functions of BookmarkNode (#2306)

Comment 2

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/690f396f2236c49fd7f67614f8bec637b74c9078
[main] Bug 1836447 - Make extension functions member functions of BookmarkNode

Comment 3

[Rahul Sainani [:rsainani]]

Note for QA, one way to test this is to confirm that metrics.mobile_bookmarks_count and metrics.desktop_bookmarks_count in the metrics ping are correct.

Comment 4

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Fenix Nightly 116.0a1 from 6/8 with Google Pixel 6 (Android 13).
The metrics pings are correct.
Glean dashboard