1836469 - document what mailnews.js and all-thunderbird.js do

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Kai Engert [:KaiE:]]

We currently have different default values for pref mail.import.in_new_tab
packaged in omni.ja:
./defaults/pref/mailnews.js
./defaults/pref/all-thunderbird.js

Is this a mistake? Should one get removed?

Because the pref values are different, does this mean we get a random pref value at runtime (or maybe always one of the files takes precedence)?

Comment 1

[Magnus Melin [:mkmelin]]

The all-thunderbird.js will take precedence over mailnews.js (which is for mailnews backend stuff theoretically shared with seamonkey).
So it's not really a bug - all-thunderbird.js is where we add something to override a default value for Thunderbird only. In many/most cases we could of course just change the mailnews.js value.
For the pref in question, seamonkey would not have the new import in tab...

Comment 2

[Kai Engert [:KaiE:]]

Thanks for the clarification.

It would help to document that as a comment at the top of those files.

Comment 3

[Kai Engert [:KaiE:]]

Magnus, do you agree to document that in a comment in the prefs files?

Comment 4

[Magnus Melin [:mkmelin]]

I guess we can do that.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1836469 - document what mailnews.js and all-thunderbird.js do. r=#thunderbird-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5dab73cd76b2
document what mailnews.js and all-thunderbird.js do. r=babolivier

Comment 7

[Kai Engert [:KaiE:]]

Thanks Magnus!