Closed Bug 1836564 Opened 1 year ago Closed 1 year ago

[css-values-4] negative <resolution> values are invalid for image-set (WPT failures in image-set-negative-resolution-rendering.html and image-set-negative-resolution-rendering-2.html)

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: mozilla-apprentice, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

A resolution was made for csswg-drafts/#8532.

[css-values-4] Specify argument range for resolution

  • RESOLVED: negative <resolution> values are invalid

Discussion.

Summary: [css-values-4] Specify argument range for resolution → [css-values-4] negative <resolution> values are invalid for image-set (WPT failures in image-set-negative-resolution-rendering.html and image-set-negative-resolution-rendering-2.html)
See Also: → 1836848
Assignee: nobody → emilio
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

Apply some clang-tidy suggestions while I was going through the
ServoStyleConstsInlines while at it.

Remove one 0x test because it's tested on the same test and causes a
harness error.

As per https://drafts.csswg.org/css-values-4/#resolution-value negative
resolutions are always invalid, even in media queries.

Attachment #9338073 - Attachment description: Bug 1836564 - Forbid negative resolutions at parse time. r=dholbert,#layout,#style → Bug 1836564 - Forbid negative CSS resolutions at parse time. r=dholbert,#layout,#style
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f77009ce2bf
Forbid negative CSS resolutions at parse time. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c5dec1d6323f
Fix media query tests. r=dholbert
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/84b1b3ec0e81
Fix Gecko's test_media_queries.html

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #5)

Failed to create upstream wpt PR due to merge conflicts. This requires fixup
from a wpt sync admin.

note: this^ may mean we need a manual pull request upstream. I think this failed [in part] because our copy of image-set-parsing.html was already out of sync, before this bug's changes. The two removed lines here (below the 222dpi line):
https://hg.mozilla.org/integration/autoland/rev/0f77009ce2bf#l7.12
...don't exist in upstream wpt:
https://github.com/web-platform-tests/wpt/blob/886b8496dc/css/css-images/image-set/image-set-parsing.html#L303

(ni=emilio to follow up on the manual pull request, unless jgraham recommends resolving comment 5 in some other way.)

Flags: needinfo?(emilio)

Ok, I suspect we can just keep the upstream version of that test. The other stuff should not have conflicts. James, do you know how to proceed? Should I send a PR for the non-image-set-parsing.html changes here? Something else?

Flags: needinfo?(emilio) → needinfo?(james)

https://github.com/web-platform-tests/wpt/pull/40461 for some other bugs in that test that hadn't made it to mozilla-central yet.

If we can just keep the upstream version of image-set-parsing, that should make it possible to resolve the conflicts, I think. Let me try.

Flags: needinfo?(james)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40494 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: