[css-values-4] negative <resolution> values are invalid for image-set (WPT failures in image-set-negative-resolution-rendering.html and image-set-negative-resolution-rendering-2.html)
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox116 | --- | fixed |
People
(Reporter: mozilla-apprentice, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
A resolution was made for csswg-drafts/#8532.
[css-values-4] Specify argument range for resolution
- RESOLVED: negative <resolution> values are invalid
Comment 1•2 years ago
•
|
||
Note: this resulted in two WPTs being updated:
https://github.com/web-platform-tests/wpt/pull/39849
https://hg.mozilla.org/mozilla-central/rev/f912edbde9cb7bd938294e766910fa4cab9f2b2d
We fail these two WPTs. until we implement this spec-change. wpt.fyi link:
https://wpt.fyi/results/css/css-images/image-set/image-set-negative-resolution-rendering.html
https://wpt.fyi/results/css/css-images/image-set/image-set-negative-resolution-rendering-2.html
These WPTs happen to be in the interop-2023-webcompat test set.
Updated•2 years ago
|
Assignee | ||
Updated•1 years ago
|
Assignee | ||
Updated•1 years ago
|
Assignee | ||
Comment 2•1 years ago
|
||
Apply some clang-tidy suggestions while I was going through the
ServoStyleConstsInlines while at it.
Remove one 0x test because it's tested on the same test and causes a
harness error.
Assignee | ||
Comment 3•1 years ago
|
||
As per https://drafts.csswg.org/css-values-4/#resolution-value negative
resolutions are always invalid, even in media queries.
Updated•1 years ago
|
Comment 7•1 years ago
|
||
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #5)
Failed to create upstream wpt PR due to merge conflicts. This requires fixup
from a wpt sync admin.
note: this^ may mean we need a manual pull request upstream. I think this failed [in part] because our copy of image-set-parsing.html
was already out of sync, before this bug's changes. The two removed lines here (below the 222dpi
line):
https://hg.mozilla.org/integration/autoland/rev/0f77009ce2bf#l7.12
...don't exist in upstream wpt:
https://github.com/web-platform-tests/wpt/blob/886b8496dc/css/css-images/image-set/image-set-parsing.html#L303
Comment 8•1 years ago
|
||
(ni=emilio to follow up on the manual pull request, unless jgraham recommends resolving comment 5 in some other way.)
Assignee | ||
Comment 9•1 years ago
|
||
Ok, I suspect we can just keep the upstream version of that test. The other stuff should not have conflicts. James, do you know how to proceed? Should I send a PR for the non-image-set-parsing.html
changes here? Something else?
Assignee | ||
Comment 10•1 years ago
|
||
https://github.com/web-platform-tests/wpt/pull/40461 for some other bugs in that test that hadn't made it to mozilla-central yet.
Comment 11•1 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0f77009ce2bf
https://hg.mozilla.org/mozilla-central/rev/c5dec1d6323f
https://hg.mozilla.org/mozilla-central/rev/84b1b3ec0e81
Comment 12•1 years ago
|
||
If we can just keep the upstream version of image-set-parsing, that should make it possible to resolve the conflicts, I think. Let me try.
Description
•