1836564 - [css-values-4] negative <resolution> values are invalid for image-set (WPT failures in image-set-negative-resolution-rendering.html and image-set-negative-resolution-rendering-2.html)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#8532.

[css-values-4] Specify argument range for resolution

• RESOLVED: negative <resolution> values are invalid

Discussion.

Comment 1

[Daniel Holbert [:dholbert]]

Note: this resulted in two WPTs being updated:
https://github.com/web-platform-tests/wpt/pull/39849
https://hg.mozilla.org/mozilla-central/rev/f912edbde9cb7bd938294e766910fa4cab9f2b2d

We fail these two WPTs. until we implement this spec-change. wpt.fyi link:
https://wpt.fyi/results/css/css-images/image-set/image-set-negative-resolution-rendering.html
https://wpt.fyi/results/css/css-images/image-set/image-set-negative-resolution-rendering-2.html

These WPTs happen to be in the interop-2023-webcompat test set.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1836564 - Forbid negative CSS resolutions at parse time. r=dholbert,#layout,#style

Apply some clang-tidy suggestions while I was going through the
ServoStyleConstsInlines while at it.

Remove one 0x test because it's tested on the same test and causes a
harness error.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1836564 - Fix media query tests. r=dholbert,#style

As per https://drafts.csswg.org/css-values-4/#resolution-value negative
resolutions are always invalid, even in media queries.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f77009ce2bf
Forbid negative CSS resolutions at parse time. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c5dec1d6323f
Fix media query tests. r=dholbert

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84b1b3ec0e81
Fix Gecko's test_media_queries.html

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #5)

Failed to create upstream wpt PR due to merge conflicts. This requires fixup
from a wpt sync admin.

note: this^ may mean we need a manual pull request upstream. I think this failed [in part] because our copy of image-set-parsing.html was already out of sync, before this bug's changes. The two removed lines here (below the 222dpi line):
https://hg.mozilla.org/integration/autoland/rev/0f77009ce2bf#l7.12
...don't exist in upstream wpt:
https://github.com/web-platform-tests/wpt/blob/886b8496dc/css/css-images/image-set/image-set-parsing.html#L303

Comment 8

[Daniel Holbert [:dholbert]]

(ni=emilio to follow up on the manual pull request, unless jgraham recommends resolving comment 5 in some other way.)

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Ok, I suspect we can just keep the upstream version of that test. The other stuff should not have conflicts. James, do you know how to proceed? Should I send a PR for the non-image-set-parsing.html changes here? Something else?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

https://github.com/web-platform-tests/wpt/pull/40461 for some other bugs in that test that hadn't made it to mozilla-central yet.

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/0f77009ce2bf
https://hg.mozilla.org/mozilla-central/rev/c5dec1d6323f
https://hg.mozilla.org/mozilla-central/rev/84b1b3ec0e81

Comment 12

[James Graham [:jgraham]]

If we can just keep the upstream version of image-set-parsing, that should make it possible to resolve the conflicts, I think. Let me try.

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40494 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot