Open Bug 1836573 Opened 2 years ago Updated 1 year ago

Don't sync `localhost` URLs

Categories

(Firefox :: Sync, enhancement)

Product:
Firefox
Component:
Sync
Platform:
All
Android
Type:
enhancement

Tracking

()

People

(Reporter: xidorn, Unassigned)

References

Details

Steps to reproduce

  1. setup syncing between a Firefox on desktop and one on Android
  2. host something on the desktop behind domains like foo.localhost
  3. visit that domain on desktop and have the history synced to Android
  4. type the prefix of the domain like "foo" on Android address bar

Expected behavior

It should not include foo.localhost in the autocomplete and address bar suggestion, because .localhost domains resolve to loopback address which generally doesn't make sense when using a different device.

Actual behavior

It includes the .localhost address in suggestion and autocomplete.

Severity: -- → N/A
Component: General → Accounts and Sync

I wonder if we should exclude loopback hostnames from syncing at all.

Component: Accounts and Sync → Sync
Product: Fenix → Firefox
Summary: Don't autocomplete URLs of .localhost domains from a different device → Don't sync `localhost` URLs

I made this comment in bug 1924747 but it applies equally here. We exclude some schemes for synced tabs via the pref https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#3882. Sadly though, syncing of history does not use that, and instead appears to exclude only file:// urls (https://searchfox.org/mozilla-central/source/services/sync/modules/engines/history.sys.mjs#99).

I thought we consolidated this some time ago, but apparently not :(

You need to log in before you can comment on or make changes to this bug.