1836586 - Perma Toolchains clang-trunk-stage1 1 out of 1 hunk ignored -- saving rejects to file llvm/lib/ObjCopy/MachO/MachOObjcopy.cpp.rej

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Iulian Moraru]

• Push where this occurred
• Failure log

[task 2023-06-03T02:34:22.919Z] [4597/4663] : && /usr/lib/llvm-13/bin/clang++ --sysroot=/builds/worker/fetches/sysroot -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -Wl,-Bsymbolic-functions -fuse-ld=lld -Wl,--icf=safe -Wl,--gc-sections -fuse-ld=lld -Wl,--color-diagnostics   -Wl,--export-dynamic tools/clang/tools/extra/clang-tidy/tool/CMakeFiles/clang-tidy.dir/ClangTidyToolMain.cpp.o -o bin/clang-tidy  -Wl,-rpath,"\$ORIGIN/../lib:/builds/worker/fetches/llvm-project/build/stage1/build/lib:"  -lpthread  lib/libclangTidy.a  lib/libclangTidyMain.a  lib/libclangTidyAndroidModule.a  lib/libclangTidyAbseilModule.a  lib/libclangTidyAlteraModule.a  lib/libclangTidyBoostModule.a  lib/libclangTidyBugproneModule.a  lib/libclangTidyCERTModule.a  lib/libclangTidyConcurrencyModule.a  lib/libclangTidyCppCoreGuidelinesModule.a  lib/libclangTidyDarwinModule.a  lib/libclangTidyFuchsiaModule.a  lib/libclangTidyGoogleModule.a  lib/libclangTidyHICPPModule.a  lib/libclangTidyLinuxKernelModule.a  lib/libclangTidyLLVMModule.a  lib/libclangTidyLLVMLibcModule.a  lib/libclangTidyMiscModule.a  lib/libclangTidyModernizeModule.a  lib/libclangTidyObjCModule.a  lib/libclangTidyOpenMPModule.a  lib/libclangTidyPerformanceModule.a  lib/libclangTidyPortabilityModule.a  lib/libclangTidyReadabilityModule.a  lib/libclangTidyZirconModule.a  lib/libclangTidyMPIModule.a  lib/libclangTidyBugproneModule.a  lib/libclangTidyCppCoreGuidelinesModule.a  lib/libclangTidyGoogleModule.a  lib/libclangTidyMiscModule.a  lib/libclangAnalysis.a  lib/libclangASTMatchers.a  lib/libclangAST.a  lib/libclangLex.a  lib/libclangBasic.a  lib/libclangTidyModernizeModule.a  lib/libclangTidyReadabilityModule.a  lib/libclangTidyUtils.a  lib/libclangTidy.a  lib/libclang-cpp.so.17git  lib/libLLVM-17git.so && :
[task 2023-06-03T02:34:22.919Z] FAILED: bin/clang-tidy 
[task 2023-06-03T02:34:22.919Z] : && /usr/lib/llvm-13/bin/clang++ --sysroot=/builds/worker/fetches/sysroot -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -Wl,-Bsymbolic-functions -fuse-ld=lld -Wl,--icf=safe -Wl,--gc-sections -fuse-ld=lld -Wl,--color-diagnostics   -Wl,--export-dynamic tools/clang/tools/extra/clang-tidy/tool/CMakeFiles/clang-tidy.dir/ClangTidyToolMain.cpp.o -o bin/clang-tidy  -Wl,-rpath,"\$ORIGIN/../lib:/builds/worker/fetches/llvm-project/build/stage1/build/lib:"  -lpthread  lib/libclangTidy.a  lib/libclangTidyMain.a  lib/libclangTidyAndroidModule.a  lib/libclangTidyAbseilModule.a  lib/libclangTidyAlteraModule.a  lib/libclangTidyBoostModule.a  lib/libclangTidyBugproneModule.a  lib/libclangTidyCERTModule.a  lib/libclangTidyConcurrencyModule.a  lib/libclangTidyCppCoreGuidelinesModule.a  lib/libclangTidyDarwinModule.a  lib/libclangTidyFuchsiaModule.a  lib/libclangTidyGoogleModule.a  lib/libclangTidyHICPPModule.a  lib/libclangTidyLinuxKernelModule.a  lib/libclangTidyLLVMModule.a  lib/libclangTidyLLVMLibcModule.a  lib/libclangTidyMiscModule.a  lib/libclangTidyModernizeModule.a  lib/libclangTidyObjCModule.a  lib/libclangTidyOpenMPModule.a  lib/libclangTidyPerformanceModule.a  lib/libclangTidyPortabilityModule.a  lib/libclangTidyReadabilityModule.a  lib/libclangTidyZirconModule.a  lib/libclangTidyMPIModule.a  lib/libclangTidyBugproneModule.a  lib/libclangTidyCppCoreGuidelinesModule.a  lib/libclangTidyGoogleModule.a  lib/libclangTidyMiscModule.a  lib/libclangAnalysis.a  lib/libclangASTMatchers.a  lib/libclangAST.a  lib/libclangLex.a  lib/libclangBasic.a  lib/libclangTidyModernizeModule.a  lib/libclangTidyReadabilityModule.a  lib/libclangTidyUtils.a  lib/libclangTidy.a  lib/libclang-cpp.so.17git  lib/libLLVM-17git.so && :
[task 2023-06-03T02:34:22.920Z] ld.lld: error: undefined symbol: clang::include_cleaner::RecordedPP::record(clang::Preprocessor const&)
[task 2023-06-03T02:34:22.920Z] >>> referenced by IncludeCleanerCheck.cpp
[task 2023-06-03T02:34:22.920Z] >>>               IncludeCleanerCheck.cpp.o:(clang::tidy::misc::IncludeCleanerCheck::registerPPCallbacks(clang::SourceManager const&, clang::Preprocessor*, clang::Preprocessor*)) in archive lib/libclangTidyMiscModule.a
[task 2023-06-03T02:34:22.920Z] 
[task 2023-06-03T02:34:22.920Z] ld.lld: error: undefined symbol: clang::include_cleaner::PragmaIncludes::record(clang::Preprocessor&)
[task 2023-06-03T02:34:22.920Z] >>> referenced by IncludeCleanerCheck.cpp
[task 2023-06-03T02:34:22.920Z] >>>               IncludeCleanerCheck.cpp.o:(clang::tidy::misc::IncludeCleanerCheck::registerPPCallbacks(clang::SourceManager const&, clang::Preprocessor*, clang::Preprocessor*)) in archive lib/libclangTidyMiscModule.a
[task 2023-06-03T02:34:22.920Z] 
[task 2023-06-03T02:34:22.920Z] ld.lld: error: undefined symbol: clang::include_cleaner::walkUsed(llvm::ArrayRef<clang::Decl*>, llvm::ArrayRef<clang::include_cleaner::SymbolReference>, clang::include_cleaner::PragmaIncludes const*, clang::SourceManager const&, llvm::function_ref<void (clang::include_cleaner::SymbolReference const&, llvm::ArrayRef<clang::include_cleaner::Header>)>)
[task 2023-06-03T02:34:22.920Z] >>> referenced by IncludeCleanerCheck.cpp
[task 2023-06-03T02:34:22.920Z] >>>               IncludeCleanerCheck.cpp.o:(clang::tidy::misc::IncludeCleanerCheck::check(clang::ast_matchers::MatchFinder::MatchResult const&)) in archive lib/libclangTidyMiscModule.a
[task 2023-06-03T02:34:22.920Z] 
[task 2023-06-03T02:34:22.920Z] ld.lld: error: undefined symbol: clang::include_cleaner::PragmaIncludes::getPublic(clang::FileEntry const*) const
[task 2023-06-03T02:34:22.920Z] >>> referenced by IncludeCleanerCheck.cpp
[task 2023-06-03T02:34:22.920Z] >>>               IncludeCleanerCheck.cpp.o:(clang::tidy::misc::IncludeCleanerCheck::check(clang::ast_matchers::MatchFinder::MatchResult const&)) in archive lib/libclangTidyMiscModule.a
[task 2023-06-03T02:34:22.920Z] 
[task 2023-06-03T02:34:22.920Z] ld.lld: error: undefined symbol: clang::include_cleaner::Include::quote[abi:cxx11]() const
[task 2023-06-03T02:34:22.920Z] >>> referenced by IncludeCleanerCheck.cpp
[task 2023-06-03T02:34:22.920Z] >>>               IncludeCleanerCheck.cpp.o:(clang::tidy::misc::IncludeCleanerCheck::check(clang::ast_matchers::MatchFinder::MatchResult const&)) in archive lib/libclangTidyMiscModule.a
[task 2023-06-03T02:34:22.920Z] 
[task 2023-06-03T02:34:22.920Z] ld.lld: error: undefined symbol: clang::include_cleaner::spellHeader[abi:cxx11](clang::include_cleaner::Header const&, clang::HeaderSearch const&, clang::FileEntry const*)
[task 2023-06-03T02:34:22.920Z] >>> referenced by IncludeCleanerCheck.cpp
[task 2023-06-03T02:34:22.920Z] >>>               IncludeCleanerCheck.cpp.o:(clang::tidy::misc::IncludeCleanerCheck::check(clang::ast_matchers::MatchFinder::MatchResult const&)) in archive lib/libclangTidyMiscModule.a
[task 2023-06-03T02:34:22.921Z] 
[task 2023-06-03T02:34:22.921Z] ld.lld: error: undefined symbol: clang::include_cleaner::Includes::match(clang::include_cleaner::Header) const
[task 2023-06-03T02:34:22.921Z] >>> referenced by IncludeCleanerCheck.cpp
[task 2023-06-03T02:34:22.921Z] >>>               IncludeCleanerCheck.cpp.o:(void llvm::function_ref<void (clang::include_cleaner::SymbolReference const&, llvm::ArrayRef<clang::include_cleaner::Header>)>::callback_fn<clang::tidy::misc::IncludeCleanerCheck::check(clang::ast_matchers::MatchFinder::MatchResult const&)::$_1>(long, clang::include_cleaner::SymbolReference const&, llvm::ArrayRef<clang::include_cleaner::Header>)) in archive lib/libclangTidyMiscModule.a
[task 2023-06-03T02:34:22.921Z] clang: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2023-06-03T02:34:23.048Z] [4598/4663] /usr/lib/llvm-13/bin/clang++ --sysroot=/builds/worker/fetches/sysroot -DCLANG_REPOSITORY_STRING=\"taskcluster-a0j17_2ATXiKyV3aJq0J9w\" -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/builds/worker/fetches/llvm-project/build/stage1/build/tools/clang/tools/extra/clangd -I/builds/worker/fetches/llvm-project/clang-tools-extra/clangd -I/builds/worker/fetches/llvm-project/clang-tools-extra/clangd/../include-cleaner/include -I/builds/worker/fetches/llvm-project/build/stage1/build/tools/clang/tools/extra/clangd/../clang-tidy -I/builds/worker/fetches/llvm-project/clang/include -I/builds/worker/fetches/llvm-project/build/stage1/build/tools/clang/include -I/builds/worker/fetches/llvm-project/build/stage1/build/include -I/builds/worker/fetches/llvm-project/llvm/include -I/builds/worker/fetches/llvm-project/clang-tools-extra/pseudo/lib/../include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -std=c++17 -MD -MT tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/HeuristicResolver.cpp.o -MF tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/HeuristicResolver.cpp.o.d -o tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/HeuristicResolver.cpp.o -c /builds/worker/fetches/llvm-project/clang-tools-extra/clangd/HeuristicResolver.cpp
<...>
[task 2023-06-03T02:34:41.530Z] [4656/4663] /usr/lib/llvm-13/bin/clang++ --sysroot=/builds/worker/fetches/sysroot -DCLANG_REPOSITORY_STRING=\"taskcluster-a0j17_2ATXiKyV3aJq0J9w\" -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/builds/worker/fetches/llvm-project/build/stage1/build/tools/clang/tools/extra/clangd -I/builds/worker/fetches/llvm-project/clang-tools-extra/clangd -I/builds/worker/fetches/llvm-project/clang-tools-extra/clangd/../include-cleaner/include -I/builds/worker/fetches/llvm-project/build/stage1/build/tools/clang/tools/extra/clangd/../clang-tidy -I/builds/worker/fetches/llvm-project/clang/include -I/builds/worker/fetches/llvm-project/build/stage1/build/tools/clang/include -I/builds/worker/fetches/llvm-project/build/stage1/build/include -I/builds/worker/fetches/llvm-project/llvm/include -I/builds/worker/fetches/llvm-project/clang-tools-extra/pseudo/lib/../include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -std=c++17 -MD -MT tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/AST.cpp.o -MF tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/AST.cpp.o.d -o tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/AST.cpp.o -c /builds/worker/fetches/llvm-project/clang-tools-extra/clangd/AST.cpp
[task 2023-06-03T02:34:41.530Z] ninja: build stopped: subcommand failed.
[task 2023-06-03T02:34:41.534Z] cd "/builds/worker/fetches/llvm-project"
[task 2023-06-03T02:34:41.534Z] Traceback (most recent call last):
[task 2023-06-03T02:34:41.534Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 843, in <module>
[task 2023-06-03T02:34:41.534Z]     main()
[task 2023-06-03T02:34:41.534Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 722, in main
[task 2023-06-03T02:34:41.534Z]     build_one_stage(
[task 2023-06-03T02:34:41.534Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 336, in build_one_stage
[task 2023-06-03T02:34:41.534Z]     build_package(build_dir, cmake_args)
[task 2023-06-03T02:34:41.534Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 121, in build_package
[task 2023-06-03T02:34:41.534Z]     run_in(package_build_dir, ["ninja", "install", "-v"])
[task 2023-06-03T02:34:41.534Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 76, in run_in
[task 2023-06-03T02:34:41.534Z]     check_run(args)
[task 2023-06-03T02:34:41.534Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 71, in check_run
[task 2023-06-03T02:34:41.534Z]     assert r == 0
[task 2023-06-03T02:34:41.534Z] AssertionError
[taskcluster 2023-06-03 02:34:42.008Z] === Task Finished ===
[taskcluster 2023-06-03 02:34:42.018Z] Artifact "public/build" not found at "/builds/worker/artifacts/": (HTTP code 404) no such container - Could not find the file /builds/worker/artifacts/ in container 9ee472c2e8de4f79c0f70b865b1f7ff8ec144f318001fc88992a0466800cab88 
[taskcluster 2023-06-03 02:34:42.110Z] Unsuccessful task run with exit code: 1 completed in 508.713 seconds

Comment 1

[Iulian Moraru]

Hi Mike! Can you please take a look at this?
Thank you!

Comment 2

[Mike Hommey [:glandium]]

Presumably fixed by https://reviews.llvm.org/rG860e439fb27f86b97bfd9acce5e27f4337c471c7

Comment 3

[Sylvestre Ledru [:Sylvestre]]

I am still getting something similar here:
https://github.com/llvm/llvm-project/issues/63087

Comment 4

[Mike Hommey [:glandium]]

Yeah, it's still happening for us too.

Comment 5

[Intermittent Failures Robot]

7 failures in 3471 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 7

Platform and build breakdown:

• toolchains: 7
  • opt: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1836586&startday=2023-05-29&endday=2023-06-04&tree=all

Comment 6

[Mike Hommey [:glandium]]

The original issue is presumably fixed by https://github.com/llvm/llvm-project/commit/ac0ea7555ee4ae872bcd153e04513ba0b88b8985 but there's a new one:

[task 2023-06-05T02:14:25.570Z] Reversed (or previously applied) patch detected!  Assume -R? [n] 
[task 2023-06-05T02:14:25.570Z] Apply anyway? [n] 
[task 2023-06-05T02:14:25.570Z] 1 out of 1 hunk ignored -- saving rejects to file llvm/lib/ObjCopy/MachO/MachOObjcopy.cpp.rej
[task 2023-06-05T02:14:25.571Z] The next patch would create the file llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-stabs.yaml,
[task 2023-06-05T02:14:25.571Z] which already exists!  Assume -R? [n] 
[task 2023-06-05T02:14:25.571Z] Apply anyway? [n] 
[task 2023-06-05T02:14:25.571Z] 1 out of 1 hunk ignored
[task 2023-06-05T02:14:25.571Z] The next patch would create the file llvm/test/tools/llvm-objcopy/MachO/strip-stabs.test,
[task 2023-06-05T02:14:25.571Z] which already exists!  Assume -R? [n] 
[task 2023-06-05T02:14:25.571Z] Apply anyway? [n] 
[task 2023-06-05T02:14:25.571Z] 1 out of 1 hunk ignored
[task 2023-06-05T02:14:25.571Z] Traceback (most recent call last):
[task 2023-06-05T02:14:25.571Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 843, in <module>
[task 2023-06-05T02:14:25.572Z]     main()
[task 2023-06-05T02:14:25.572Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 641, in main
[task 2023-06-05T02:14:25.572Z]     patch(p, source_dir)
[task 2023-06-05T02:14:25.572Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 93, in patch
[task 2023-06-05T02:14:25.572Z]     check_run(["patch", "-d", srcdir, "-p1", "-i", patch, "--fuzz=0", "-s"])
[task 2023-06-05T02:14:25.572Z]   File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 71, in check_run
[task 2023-06-05T02:14:25.572Z]     assert r == 0
[task 2023-06-05T02:14:25.572Z] AssertionError

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1836586 - Adjust local clang patches after D151864 landed upstream.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834436

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/019009b60f0a
Adjust local clang patches after D151864 landed upstream. r=firefox-build-system-reviewers,ahochheiden

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/019009b60f0a

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Intermittent Failures Robot]

2 failures in 3885 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform and build breakdown:

• toolchains: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1836586&startday=2023-06-05&endday=2023-06-11&tree=all