Closed
Bug 1836633
Opened 2 years ago
Closed 2 years ago
Translations panel menupopup covers the settings gear button
Categories
(Firefox :: Translations, defect)
Firefox
Translations
Tracking
()
RESOLVED
FIXED
116 Branch
Tracking | Status | |
---|---|---|
firefox116 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
References
Details
Attachments
(2 files)
No description provided.
The fix here should be 2-fold:
- Add
"after_end"
here: https://searchfox.org/mozilla-central/rev/f5dde549cca5193743d11daa1c5f08258bee9d42/browser/components/translations/content/translationsPanel.js#893 - Move the menupopup elsewhere, because then :hover and :hover:active on the menuitems will affect the settings gear button itself. While this should be somewhat fine for :hover, it will definitely look weird for :hover:active.
Updated•2 years ago
|
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Comment 3•2 years ago
|
||
The severity field is not set for this bug.
:anatal, could you have a look please?
For more information, please visit BugBot documentation.
Flags: needinfo?(anatal)
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/31d5ffaf0b16
Align the translation panel's settings gear menupopup with its button, and move the menupopup itself to main-popupset.inc.xhtml r=gregtatum
Comment 5•2 years ago
|
||
Backed out for causing bc failures in browser_translations_panel_always_translate_language.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/components/translations/tests/browser/browser_translations_panel_always_translate_language.js | Uncaught exception in test bound test_toggle_always_translate_language_menuitem - Waiting for checkbox state - timed out after 50 tries.
Flags: needinfo?(itiel_yn8)
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/68539279d964
Align the translation panel's settings gear menupopup with its button, and move the menupopup itself to main-popupset.inc.xhtml r=gregtatum
Comment 7•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Updated•2 years ago
|
Flags: needinfo?(anatal)
Updated•2 years ago
|
QA Whiteboard: [qa-116b-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•