1836695 - Go-to-def does not work on call to NotifyInternal() in MediaEventForwarder::NotifyIf()

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Botond Ballo [:botond]]

Steps to reproduce

1. Load MediaEventSource.h
2. In MediaEventForwarder::ForwardIf(), click on NotifyInternal() (permalink)

Expected results

Go-to-definition is offered and takes you to MediaEventSourceImpl::NotifyInternal().

Actual results

Go-to-definition is not offered

Comment 1

[Botond Ballo [:botond]]

Unlike the examples in bug 1781178, this is a case where clangd does not find a semantic target either. (It has a heuristic where it takes the textual search results, filters them for locations which are definitions of some symbol, and offers those as a fallback, but this is of course inaccurate, e.g. it sweeps up the completely unrelated WebRenderBridgeParent::NotifyInternal() as a result too.)

However, in this case resolving the target semantically should be possible (for both clangd and Searchfox).

Comment 2

[Botond Ballo [:botond]]

The underlying issue was fixed upstream in HeuristicResolver.

Comment 3

[Botond Ballo [:botond]]

mozsearch PR: https://github.com/mozsearch/mozsearch/pull/637

Also deployed to dev.searchfox.org to demonstrate that the PR fixes the original issue on m-c.

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1836695 - Pick up latest HeuristicResolver updates from llvm trunk. r=asuth

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/739f86c0b6b9
Pick up latest HeuristicResolver updates from llvm trunk. r=andi DONTBUILD

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/739f86c0b6b9