1837059 - Stray reference to GMS for annotation

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Tad]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:113.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

Compile Firefox 114 without Play Services

Actual results:

It fails:

e: file:///mnt/fdroid/fdroiddata/build/us.spotco.fennec_dos/fenix/app/src/main/java/org/mozilla/fenix/browser/readermode/ReaderModeController.kt:11:38 Unresolved reference: util
e: file:///mnt/fdroid/fdroiddata/build/us.spotco.fennec_dos/fenix/app/src/main/java/org/mozilla/fenix/browser/readermode/ReaderModeController.kt:32:6 Unresolved reference: VisibleForTesting
e: file:///mnt/fdroid/fdroiddata/build/us.spotco.fennec_dos/fenix/app/src/main/java/org/mozilla/fenix/browser/readermode/ReaderModeController.kt:39:6 Unresolved reference: VisibleForTesting

Expected results:

It compiles

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837059 - Remove stray GMS reference for annotation (#2345)

Comment 2

[BMO Github Automation]

Authored by https://github.com/SkewedZeppelin
https://github.com/mozilla-mobile/firefox-android/commit/9282051f7c80265955c17da2ba07c6d81ee7123d
[main] Bug 1837059 - Remove stray GMS reference for annotation

Comment 3

[Adina Petridean QA [:apetridean]]

Hello Tad,

Is QA verification needed for this issue? If so, could you please provide us with some steps to reproduce (STR) or testing scenarios?
Thank you!

Comment 4

[Tad]

I don't think so, as per last time: https://bugzilla.mozilla.org/show_bug.cgi?id=1822392#c3

It would be nice perhaps if there was a check for this so it doesn't happen a third time.
But I'm not sure how that'd be handled.

Comment 5

[Adina Petridean QA [:apetridean]]

Thank you Tad!