Closed Bug 1837429 Opened 1 year ago Closed 1 year ago

Rename hasShoppingTab to shoppingTabDisplayed to make it more consistent with reporting

Categories

(Firefox :: Search, task, P2)

task

Tracking

()

VERIFIED FIXED
116 Branch
Tracking Status
firefox-esr115 --- verified
firefox115 --- verified
firefox116 --- verified
firefox117 --- verified

People

(Reporter: jteow, Assigned: jteow)

References

Details

Attachments

(1 file)

The logger here can be confusing to interpret because the property names differs from how we report it in Glean.

Updated the story to instead change the naming convention altogether.

Summary: Make logging of SERP impression event more consistent → Rename hasShoppingTab to shoppingTabDisplayed to make it more consistent with reporting
Assignee: nobody → jteow
Status: NEW → ASSIGNED
Pushed by jteow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0ff8e58eb2b
Rename hasShoppingTab to shoppingTabDisplayed - r=scunnane
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

Comment on attachment 9338100 [details]
Bug 1837429 - Rename hasShoppingTab to shoppingTabDisplayed - r?scunnane

Beta/Release Uplift Approval Request

  • User impact if declined: Improvement to new Search SERP Ad telemetry that we would like to turn on a bit earlier.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple field name changes so that the intent is clearer.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9338100 - Flags: approval-mozilla-release?

Comment on attachment 9338100 [details]
Bug 1837429 - Rename hasShoppingTab to shoppingTabDisplayed - r?scunnane

Approved for 115.0.2
Approved for 115.0.2esr

Attachment #9338100 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9338100 - Flags: approval-mozilla-esr115+

Verfied as fixed with Fx115.0.2ESR, 115.0.2, Fx116.0b4, 117.0a1 (2023-07-10) on Windows 10, Ubuntu 22.04 and Mac 13.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: