1837464 - ./mach test testing/web-platform/tests/html/canvas/ fails to build ujson

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

I get the following failure when trying to run ./mach test

Building wheels for collected packages: ujson
  Building wheel for ujson (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for ujson (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      running bdist_wheel
      running build
      running build_ext
      building 'ujson' extension
      creating build
      creating build/temp.macosx-10.15-x86_64-cpython-311
      creating build/temp.macosx-10.15-x86_64-cpython-311/deps
      creating build/temp.macosx-10.15-x86_64-cpython-311/deps/double-conversion
      creating build/temp.macosx-10.15-x86_64-cpython-311/deps/double-conversion/double-conversion
      creating build/temp.macosx-10.15-x86_64-cpython-311/lib
      creating build/temp.macosx-10.15-x86_64-cpython-311/python
      /Users/jrmuizel/.mozbuild/clang/bin/clang -isysroot /Users/jrmuizel/.mozbuild/MacOSX13.3.sdk -mmacosx-version-min=10.12 -std=gnu99 -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -isysroot /Users/jrmuizel/.mozbuild/MacOSX13.3.sdk -mmacosx-version-min=10.12 -std=gnu99 -arch x86_64 -I./python -I./lib -I./deps/double-conversion/double-conversion -I/Users/jrmuizel/source/gecko-inbound/obj-opt/_virtualenvs/wpt/include -I/usr/local/opt/python@3.11/Frameworks/Python.framework/Versions/3.11/include/python3.11 -c ./deps/double-conversion/double-conversion/bignum-dtoa.cc -o build/temp.macosx-10.15-x86_64-cpython-311/./deps/double-conversion/double-conversion/bignum-dtoa.o -D_GNU_SOURCE
      error: invalid argument '-std=gnu99' not allowed with 'C++'
      error: command '/Users/jrmuizel/.mozbuild/clang/bin/clang' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for ujson
Failed to build ujson
ERROR: Could not build wheels for ujson, which is required to install pyproject.toml-based projects
Error running mach:

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jgraham, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[James Graham [:jgraham]]

Looks like we're using 4.0.2 which only has 3.6-3.9 wheels, and the latest version only has 3.8+.

In practice ujson isn't actually required, it just makes things faster. I'm not sure what the best way to proceed is; maybe in https://searchfox.org/mozilla-central/source/python/sites/wpt.txt#2 we could try using different versions according to the Python version? We could also in theory just delete it from there, but that would involve a perf loss. We could also consider switching to orjson, which seems to have wheels for 3.7-3.11 and claims even better performance.

Comment 3

[James Graham [:jgraham]]

Attachment: Bug 1837464 - Update ujson to 5.10.0,

This has wheels for Python 3.8 to 3.13

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6662664b8114
https://hg.mozilla.org/integration/autoland/rev/860033f02383
Update ujson to 5.10.0, r=Sasha

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/860033f02383