Closed
Bug 1837507
Opened 2 years ago
Closed 2 years ago
Ensure the Compose Top Sites pager indicator aligns with the existing design
Categories
(Firefox for Android :: Top Sites, task, P3)
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
Details
(Whiteboard: [fxdroid])
Attachments
(1 file)
We want to align the PagerIndicator used in the Compose Top Sites (hidden behind a secret setting) with the existing xml PagerIndicator.
There are 2 changes here:
- We want to add a
spaceparameter to PagerIndicator and use the spacing specified by DOT_MARGIN - We need to change the padding specified in TopSites#L125 to follow https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/res/layout/component_top_sites_pager.xml#9-10. We want to keep the horizontal padding as 16dp and add a top Spacer of height 8dp.
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
|
||
Comment 1•2 years ago
|
||
|
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/1119301212d1080cd3baf2d00a2e3a367440e104
[main] Bug 1837507 - Ensure the Compose Top Sites pager indicator aligns with the existing design
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox116:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
|
|
Assignee | |
Updated•2 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•