Submit contile impressions for the Compose Top Sites
Categories
(Firefox for Android :: Top Sites, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | verified |
People
(Reporter: gl, Assigned: harrisono)
References
Details
(Whiteboard: [fxdroid])
Attachments
(1 file)
We want to reimplement the following telemetry ping for our Compose Top Sites (hidden behind a secret setting): https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt#189
We should send a telemetry ping when the contile top sites are rendered. We might want to consider doing something similar as https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/onboarding/view/OnboardingPage.kt#162-163 which uses a LaunchedEffect to submit the ping. We do not want this ping to be submitted more than necessary.
Updated•3 years ago
|
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/005122598ea405d2bd05880f6d367726ae96bf86
[main] Bug 1837524 - Contile Top Sites impression probe in Compose Top Sites
Comment 3•2 years ago
|
||
Verified as fixed on the latest Nightly (118.0a1) from 8th of August 2023.
The following ping is sent: "top_sites.contile_impression"
For more details, see the Glean telemetry: https://debug-ping-preview.firebaseapp.com/pings/amocirean3/af9da140-97ad-41b2-a680-d02975621cb5
Thanks!
Updated•2 years ago
|
Description
•