1837551 - [gv-junit-fis] Timeouts in junit tests that use session history

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[[:owlish] 🦉 PST]

List of tests affected:

• HistoryDelegateTest#onHistoryStateChangeSavingState
• NavigationDelegateTest#purgeHistory
• NavigationDelegateTest#goBackFromHistory
• ProgressDelegateTest#saveAndRestoreStateNewSession
• ProgressDelegateTest#saveAndRestoreState
• ProgressDelegateTest#flushSessionState
• ProgressDelegateTest#noHistoryDelegateOnSessionStateChange
• ScreenshotTest#capturePixelsWhileSessionDeactivated
• WebExtensionTest#testRestoringExtensionPagePreservesMessages

Comment 2

[Chris Peterson [:cpeterson]]

Assigning to Kaya for now because his SHIP patches should fix these failures.

Comment 4

[Kaya [:kaya]]

Reopening this as this ticket specifically refers to the disabled tests due to the fission pref checks. I accidentally closed it as a dup of the SHIP-disabled tests.
For this ticket, I'll be removing the fission pref checks in the tests.

Comment 5

[Kaya [:kaya]]

Attachment: Bug 1837551 - Enable the disabled Android instrumentation tests (except ScreenshotTest#capturePixelsWhileSessionDeactivated) for Fission.

SessionHistoryInParent(SHIP) is refactored as a part of SHIP on Android project. With the refactored codepath, these disabled tests started passing for Fission. This patch enables those tests back.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26e0cc20a78e
Enable the disabled Android instrumentation tests (except ScreenshotTest#capturePixelsWhileSessionDeactivated) for Fission. r=geckoview-reviewers,owlish

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/26e0cc20a78e

Comment 8

[[:owlish] 🦉 PST]

Hey Kaya, what is the status on this - is there more work left to be done? (just seeing it has leave-open tag) Thanks!

Comment 9

[Kaya [:kaya]]

Yes, I have an ongoing work on fixing ScreenshotTest#capturePixelsWhileSessionDeactivated test which is the only left-over. Once that's fixed, this ticket will be closed.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:kaya, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Comment 11

[Kaya [:kaya]]

ScreenshotTest#capturePixelsWhileSessionDeactivated is fixed in https://phabricator.services.mozilla.com/D210759. Closing this ticket.