1837639 - Signing out of Sync takes Firefox View back to mobile setup instead of showing a disconnected error

Status: RESOLVED WONTFIX

(Firefox :: Firefox View, defect, P3)

Description

[Mike Kaply [:mkaply]]

This is legacy sync (but will impact new sync).

If you login to sync and go to view, you'll see synced tabs.

If you then logout, and go back to view, you'll get the mobile setup.

You shouldn't. You should get a message about being disconnected. This is happening because after you signout, lazy.UIState.get().status here - https://searchfox.org/mozilla-central/source/browser/components/firefoxview/firefox-view-synced-tabs-error-handler.sys.mjs#80 returns "not_configured"

We should add an extra check for the preference - services.sync.lastversion.

If that pref is set, the user was logged into sync at some point.

Comment 1

[Mike Kaply [:mkaply]]

As usual, this got a bit complicated. I fixed the error handler, but because the UI state is still stuck at 1, we don't show the error message.

We should be setting the UI state to 0 after we've logged in.

I'm going to punt on this for now since it's not going to be an issue with the new view.

Comment 2

[Sam Foster [:sfoster] (he/him)]

This was a design decision from the original implementation, but I agree that a disconnected message would be better.

Comment 3

[Sarah Clements [:sclements] | PTO until July 14th]

I'm not seeing this with the new Firefox View.... just a "Sign in to reconnect" message. It sounds like this about the old firefox view, so I'm going to close it. If I'm wrong and I'm missing a STR, please reopen.