1838162 - Use ExtensionError instead of Error in WebExtension APIs

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, task)

Description

[John Bieling]

Instead of the correct error message, throw new Error(...) only adds an "unexpected error" message to the console:

Uncaught (in promise) Error: An unexpected error occurred

We should use ExtensionError.

Comment 1

[John Bieling]

Attachment: Bug 1838162 - Use ExtensionError instead of Error in WebExtension APIs. r=#thunderbird-reviewers

Depends on D180678

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/934515a0e1aa
Use ExtensionError instead of Error in WebExtension APIs. r=mkmelin

Comment 3

[John Bieling]

Comment on attachment 9338813 [details]
Bug 1838162 - Use ExtensionError instead of Error in WebExtension APIs. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
This is work which was not completed in time for 115. This is a cosmetic change (the developer gets a proper error message instead of "unexpected error". Its uplift is mainly needed to not divert 115 and daily too much, to still be able to uplift later changes without merge conflicts.

Testing completed (on c-c, etc.):
Just landed on Daily.

Risk to taking this patch (and alternatives if risky):
There should be none.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9338813 [details]
Bug 1838162 - Use ExtensionError instead of Error in WebExtension APIs. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/d999135c8083