Closed
Bug 1838216
Opened 3 years ago
Closed 3 years ago
firefox-android: GV updates can merge while breaking fenix/focus ui tests
Categories
(Release Engineering :: General, defect, P1)
Release Engineering
General
Tracking
(firefox116 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: jcristau, Assigned: jcristau)
Details
Attachments
(1 file)
GV updates come in as PRs created by github-actions[bot], which is untrusted, so the PR graph doesn't include ui tests. Because we only require complete-pr success before we'll automatically merge those PRs, breakage can come in.
Because the head repo for those PRs is the main firefox-android repo, they also have a push graph, which does trigger ui tests, so we can require green complete-push in addition to make sure to test everything.
|
Assignee | |
Comment 1•3 years ago
|
||
Assignee: nobody → jcristau
Status: NEW → ASSIGNED
|
||
Comment 2•3 years ago
|
||
Authored by https://github.com/jcristau
https://github.com/mozilla-mobile/firefox-android/commit/e88ab9ba8e37e6bbb5755da1547815de303893ad
[main] Bug 1838216 - mergify: require successful complete-push task for geckoview updates
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox116:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•