Closed Bug 1838272 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 40523 - Further DOM Parts hierarchy reorg, and connect Document to Parts

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40523 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40523
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Further DOM Parts hierarchy reorg, and connect Document to Parts

In implementing the connection between DocumentPart and Document,
it became apparent that there were other issues with the previous
hierarchy. Notably, Document owned DocumentPart, which was a Part,
which therefore had a |root| reference back to DocumentPart. That
made it impossible to require Part to always have a |root|.

This CL revamps the hierarchy once more, to this:

         PartRoot (getParts, clone)
          /    \

DocumentPartRoot Part (root, metadata)
/
NodePart (node) ChildNodePart (prev/next/etc)

With that, a Part always has a reference to its |root|, and the
DocumentPartRoot can be owned by Document and always non-nullptr.

This CL also connects DocumentFragment to DocumentPartRoot.

Bug: 1453291
Change-Id: Ic0f34d3572321cf12fb960d75243e05462c9fe84
Reviewed-on: https://chromium-review.googlesource.com/4604678
WPT-Export-Revision: b6b4655efb95f0d950954db98dc06e688879c034

PR 40523 applied with additional changes from upstream: 75e54faea56a60093e172029bb5411f7152af56a
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec3b791b979a [wpt PR 40523] - Further DOM Parts hierarchy reorg, and connect Document to Parts, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ec3b791b979a

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.