Closed Bug 1838340 Opened 3 years ago Closed 3 years ago

New wpt failures in /css/css-scrollbars/scrollbar-width-014.html

Categories

(Core :: Layout: Scrolling and Overflow, defect)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: wpt-sync, Unassigned)

References

Details

(Whiteboard: [wpt])

Syncing wpt PR 40276 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

  • /css/css-scrollbars/scrollbar-width-014.html [wpt.fyi]
    • scrollbar-width thin on the body doesn't override ::-webkit-scrollbar on root: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1835529 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

This test uses -webkit-scrollbar

Mdn https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar says "This feature is non-standard and is not on a standards track." and "Note: ::-webkit-scrollbar is only available in Blink- and WebKit-based browsers (e.g., Chrome, Edge, Opera, Safari, all browsers on iOS, and others). A standardized method of styling scrollbars is available with scrollbar-color and scrollbar-width, but is currently only supported in Firefox."

Should -webkit-scrollbar be used in a webplatform test?

(In reply to Timothy Nikkel (:tnikkel) from comment #1)

Should -webkit-scrollbar be used in a webplatform test?

ni?jgraham for this

Flags: needinfo?(james)

Hello I wrote this test. It should have been written in such a way that Firefox passed it. The fact it's failed means I've messed up. Apologies for this I will look into it and submit a fix.

https://github.com/web-platform-tests/wpt/pull/40644 Here's a fix for the immediate issue that this is failing in Firefox.

As for whether ::-webkit-scrollbar should be used that's a good question. I wrote them as WPT tests as they'd benefit both WebKit and Chromium and don't impact on Firefox (well that was the plan...). I also factored in that I know there's talk of Firefox potentially supporting a subset of this pseudo. Apologies if this was a mistake I'll make sure to factor this in in future tests.

This issue can be closed now the test was updated to fix the fact it erroneous failed in Firefox.

Thanks for fixing!

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(james)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.