1838354 - Rework and refresh the rust workspace hack

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1838354 - Change how the rust workspace hack is added.

First, instead of using a path, use a version, which is more convenient
(via a patch in the top-level Cargo.toml).

Second, we make the build system itself enforce its presence for any
crate that is hooked to the build system as a program or library.

Finally, for each crate depending on the workspace hack, we add a
feature named after it, and make the build system enforce that the
feature is set. For now, this remains unused, but the end goal is to
have each of those features enable the dependencies each of these
crates need, so that if crate A and B need dependency D, but crate C
doesn't, building crate C doesn't build D.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1838354 - Refresh the rust workspace hack.

It had been neglected for a long time, and the enabled features were
outdated, and plenty of now common crates were missing.

This refresh required ad-hoc, flawed scripts to reach that updated
Cargo.toml. Eventually we'll want this refresh to be automated, but
the existing tools don't quite work for our use case just yet. Rather
than waiting that such a state is reached, go ahead with this manual
update which improves a lot compared to the status quo.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d56073d9252c
Change how the rust workspace hack is added. r=firefox-build-system-reviewers,webdriver-reviewers,ahochheiden,whimboo
https://hg.mozilla.org/integration/autoland/rev/ad89174d6840
Refresh the rust workspace hack. r=firefox-build-system-reviewers,supply-chain-reviewers,ahochheiden

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d56073d9252c
https://hg.mozilla.org/mozilla-central/rev/ad89174d6840

Comment 5

[Gabriele Svelto [:gsvelto]]

If I try to vendor some rust crates after this patch landed cargo vet complains. This is the output of cargo vendor rust:

 0:24.22 Vet error: There are some issues with your policy.audit-as-crates-io entries
 0:24.44  related error: Some non-crates.io-fetched packages match published crates.io versions
  mozilla-central-workspace-hack:0.1.0

And this is what cargo-vet has to say:

Error:
  × Some non-crates.io-fetched packages match published crates.io versions
  │   mozilla-central-workspace-hack:0.1.0
  help: Add a `policy.*.audit-as-crates-io` entry for them

Comment 6

[Mike Hommey [:glandium]]

Oh right, I published the crate after the fact... and cargo vet doesn't like that.

Comment 7

[Mike Hommey [:glandium]]

Weirdly enough... I can't reproduce.

Comment 8

[Gabriele Svelto [:gsvelto]]

Indeed this doesn't happen on Linux, only on Windows ¯_(ツ)_/¯

Sorry for the noise

Comment 9

[msirringhaus]

Hm, I see the same problem on Linux, though.
clobber didn't help (not sure if it would do anything relevant, but it was the first thing that came to mind).

Comment 10

[Jeff Muizelaar [:jrmuizel]]

I see the the same problem on macOS