1838438 - Insert sidebar into the XUL DOM

Status: RESOLVED FIXED

(Firefox Graveyard :: Shopping, task, P2)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We created the basic chrome://browser/content/shopping/shopping.html page, now let's get it inserted into the XUL DOM.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: WIP: Bug 1838438 - Insert the shopping sidebar into the XUL DOM

The rough approach here is to insert the sidebar into the XUL DOM as a
shopping-sidebar custom element with a url attribute that is
observed by the component. On attribute update, the URL is relayed to
the shopping.html browser el by setting the url as its query string,
which causes the shopping page to reload. An onload listener in the
shopping page picks up the new product URL and can hand it off to the
API components when ready.

Does this approach make sense?

Note that I haven't yet styled the frame, but it's there.

I also haven't set up the actors yet--would it be better if the actors
instead manage sending down the URL?

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1838438 - Insert shopping sidebar into the XUL DOM. r?mossop

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27dfafd3d2a2
Insert shopping sidebar into the XUL DOM. r=mossop

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing nightlyasrelease browsertime failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=27dfafd3d2a2efe57272d05468e809a8ab27dc57&selectedTaskRun=aKYDyvOsS7y34lWBE7xWyw.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=421602144&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=421593334&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/0e8e81c68d5f2b8d0058d18c9692c610f37b52bc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ee0830a782d
Insert shopping sidebar into the XUL DOM. r=mossop

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks, sorry for the bustage. Think I've got it sorted this time.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3ee0830a782d