1838555 - Some requests loaded from cache are logged as `NS_BINDING_ABORTED`

Status: ASSIGNED

(DevTools :: Netmonitor, defect, P2)

Description

[6k64x4ma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. Launch Firefox with a new profile.
2. Go to http://pc.ypc.shq.azito.co.jp/page/static/terms
3. Open the Network Monitor.
4. Reload the page.

Actual results:

• Some requests are logged as NS_BINDING_ABORTED.
  But these images were successfully loaded (maybe from cache).

Expected results:

• These requests should be logged as cached.

mozregression:

2023-06-15T09:30:34.549000: DEBUG : Found commit message:
Bug 1820200 - [devtools] Fix and enable browser_resources_network_events.js test r=jdescottes,devtools-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D172581

2023-06-15T09:30:34.549000: DEBUG : Did not find a branch, checking all integration branches
2023-06-15T09:30:34.565000: INFO : The bisection is done.
2023-06-15T09:30:34.565000: INFO : Stopped

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:bomsy, since you are the author of the regressor, bug 1820200, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1838555 - [devtools] Ignore requests with NS_BINDING_ABORTED, since they emmited from the cache r=#devtools-reviewers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1820200

Comment 4

[Pascal Chevrel:pascalc]

Hubert, could you set the priority and severity fields please? Thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddccbe26cba6
[devtools] Ignore requests with NS_BINDING_ABORTED, since they emmited from the cache r=devtools-reviewers,ochameau

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ddccbe26cba6

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1820200

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bomsy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9339223 [details]
Bug 1838555 - [devtools] Ignore requests with NS_BINDING_ABORTED, since they emmited from the cache r=#devtools-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: User will see cached request showing up
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch to filter out the NS_BINDING_ABORTED status for cached requests
• String changes made/needed:
• Is Android affected?: No

Comment 10

[6k64x4ma]

Attachment: screenshot.webp

Hi, I'm still seeing the same issue on bugzilla.mozilla.org.
(I can't reproduce it on http://pc.ypc.shq.azito.co.jp/page/static/terms, so something may have been changed on the server side.)

Tested on Nightly (Build ID 20230706171901).

Steps to reproduce:

1. Set network.http.rcwn.enabled to false.
2. Go to https://bugzilla.mozilla.org/describecomponents.cgi
3. Open the Network Monitor.
4. Reload the page.

Actual result:
Some images are reported as NS_BINDING_ABORTED.

Can you take a look?

Comment 11

[Dianna Smith [:diannaS]]

:bomsy could you take a look at comment 10 before we accept this for uplift?

Comment 12

[Hubert Boma Manilla (:bomsy)]

Hmm i can see the issue(In reply to 6k64x4ma from comment #10)

Created attachment 9342708 [details]
screenshot.webp

Hi, I'm still seeing the same issue on bugzilla.mozilla.org.
(I can't reproduce it on http://pc.ypc.shq.azito.co.jp/page/static/terms, so something may have been changed on the server side.)

Tested on Nightly (Build ID 20230706171901).

Steps to reproduce:

1. Set network.http.rcwn.enabled to false.
2. Go to https://bugzilla.mozilla.org/describecomponents.cgi
3. Open the Network Monitor.
4. Reload the page.

Actual result:
Some images are reported as NS_BINDING_ABORTED.

Can you take a look?

Hmm ... i can see the issue on bugzilla. I'll take a look.

Dianna, I think we can cancel the uplift. Thanks

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Reopening based on comments 11 & 12 since it sounds like the patch that landed didn't fully resolve the issue.