1838602 - [a11y] Increase "Download" button size in the PDF viewer

Status: RESOLVED FIXED

(GeckoView :: PDF Viewer, defect, P1)

Description

[Adina Petridean QA [:apetridean]]

Steps to reproduce

1. Have the Accessibility scanner app installed and opened.
2. Launch Fenix.
3. Open a PDF page (e.g. https://www.africau.edu/images/default/sample.pdf)
4. Scan the PDF page.

Expected behavior

No suggestions are made.

Actual behavior

This item's height is 18dp. Consider making the height of this touch target 48 dp or larger.

Device information

• Firefox version: Nightly 116.0a1 from 14.06.2023
• Android device model: Motorola Moto G9 plus
• Android OS version: Android 11

Any additional information?

Comment 1

[Adina Petridean QA [:apetridean]]

Attachment: download2.JPEG

Comment 2

[Adina Petridean QA [:apetridean]]

Attachment: Open in app.JPEG

Comment 3

[Anna Yeddi [:ayeddi]]

In the Downloads button case, it looks like the icon should've been included in the touch target size calculation (maybe the Open in app text is also associated with the icon on the left, thus should be included in the size calculation too). That's being said, it appears that the height of controls would still be smaller than expected. More on touch target sizes on Android in the BBC A11y Guide

Comment 5

[Mihai Adrian Carare [:mcarare]]

Moving to PDF component since the buttons are not shown from Fenix.

Comment 6

[Cathy Lu [:calu]]

Looks like this may be handled by pdf.js and not Fenix. Any idea on if we can fix this?

Comment 7

[Calixte Denizet (:calixte)]

Yes it's pretty high on my todo list and I should do it in the next weeks.

Comment 8

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [GV] Increase the height (48px) of the toolbar in order to fit the a11y recommandations (bug 1838602) (#18837)