1838632 - Stop using non-standard attributes as a DTD migration legacy and lint for reoccurrences

Status: RESOLVED FIXED

(Firefox :: General, task, P1)

Description

[:Gijs (out for now; he/him)]

bug 1838549 happened because the content used to be localized using DTDs (which were processed at HTML/XUL-parse time), and used JS to update labels dynamically based on the non-standard attributes. When migrating to fluent, this ended up inadvertently depending on l10n timing, because the attribute could be blank if fluent translation hadn't happened yet at the point where the JS ran.

This is a bad pattern, full stop - the JS should just switch to a different l10n ID. The pre-fix-in-bug1838549 code was not only racy, but also would not work well if the document was retranslated after a language update, because the "real" label would not have been updated until the JS re-ran.

I have a WIP patch that lints for non-standard attributes, and it's found a few other instances of this, plus some cases where we've accidentally used a non-meaningful attribute (e.g. "tooltip") when we intended to use a "real" one (like "tooltiptext"), so a linter seems like it'd be useful.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Migration' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (out for now; he/him)]

Bad bugbot, no botsnacks for you.

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Bug 1838632 - make fluent-lint complain about unknown attributes, r?flod

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Bug 1838632 - fix connection dialog autologin checkbox to have a tooltip as intended, r?#settings-reviewers

Depends on D181228

Comment 5

[:Gijs (out for now; he/him)]

Attachment: Bug 1838632 - fix edit bookmarks dialog's use of non-standard fluent attributes to use more straightforward switches between messages, r?jsudiaman!

Depends on D181229

Comment 6

[:Gijs (out for now; he/him)]

Attachment: Bug 1838632 - comment and/or adjust some devtools uses of non-standard attributes in fluent, r?#devtools-reviewers

Depends on D181230

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d8cda133356
make fluent-lint complain about unknown attributes, r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/153a0ea81f77
fix connection dialog autologin checkbox to have a tooltip as intended, r=fluent-reviewers,flod,mconley
https://hg.mozilla.org/integration/autoland/rev/547458ae6707
fix edit bookmarks dialog's use of non-standard fluent attributes to use more straightforward switches between messages, r=jsudiaman,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/e7e1efea4e06
comment and/or adjust some devtools uses of non-standard attributes in fluent, r=devtools-reviewers,fluent-reviewers,nchevobbe,flod

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2d8cda133356
https://hg.mozilla.org/mozilla-central/rev/153a0ea81f77
https://hg.mozilla.org/mozilla-central/rev/547458ae6707
https://hg.mozilla.org/mozilla-central/rev/e7e1efea4e06