183876 - MachO builds create a bad PkgInfo file in the bundle

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[James Turner]

in xpfe/bootstrap/Makefile.in, as part of constructing the bundle for the MachO
build, we do:
 echo APPLMOZZ > $(DIST)>/$(APP_NAME).app/Contents/PkgInfo

As it turns out, this is subtly wrong, but I only found this out when calling
CFBundleGetPackageInfo : it returned empty values for us. The problem is echo is
appending a newline to the PkgInfo file, so it comes out as 9 bytes long, not 8.
This seems to matter to the CFBundle code (though maybe this is version dependent).

In any case, switching to 'echo -n' works (stops it outputing the trailing newline).

Comment 1

[James Turner]

Attachment: Implement GetBindingParent on genericDOMDataNode

Comment 2

[James Turner]

Comment on attachment 108471 [details] [diff] [review]
Implement GetBindingParent on genericDOMDataNode

oops, wrong bug :-(

Comment 3

[Conrad Carlen (not reading bugmail)]

> In any case, switching to 'echo -n' works

Sounds reasonable to me. No matter how trivial, put up a patch so we have
something to r= :-)

Comment 4

[hacker formerly known as [e-mail]]

Attachment: use echo -n

Comment 5

[Conrad Carlen (not reading bugmail)]

Comment on attachment 108536 [details] [diff] [review]
use echo -n

:-) r=ccarlen

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 108536 [details] [diff] [review]
use echo -n

a=asa for checkin to 1.3a

Comment 7

[hacker formerly known as [e-mail]]

Patch has been checked in.