1838778 - [perma opt-builds only] comm/mail/test/browser/account/browser_archiveOptions.js | 0 == 1 - {"filename":"chrome://mochitests/content/browser/comm/mail/test/browser/account/browser_archiveOptions.js","name":"subtest_initial_state

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=419409479&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VxmRRCHAQTSabv4CADPykQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

Not seeing it locally on a slightly outdated m-c, so probably something from there.
First seeing it https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=VxmRRCHAQTSabv4CADPykQ.0&revision=9ca1cd4698e95e227dec8e6b857fbfb4398101fa which means something from https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=6a3e558888107e82ba443f0ce749cd51f6e1b385

Comment 2

[Magnus Melin [:mkmelin]]

Haven't worked out what caused it, but I do have a fix. The dialog had sizing issues that made the dialog buttons off screen now. (When no persisted size existed). Given the area, probably one of Emilios fixes in that range somehow exposed this.

115 may not have the test failure, but the fix should probably get applied there anyway. The actual issue may present itself...

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1838778 - Fix archiveoptions dialog sizing issues. r=#thunderbird-reviewers

widht and height don't apply after modern flexbox.
We really shouldn't be presising these kind of sizes. They need to work for everyone without haveing to resize or something is wrong.
Made it slightly wider than it used to. No need to have it super narrow. Some locales may have longer texts and then it wouldn't look as good.

Comment 4

[Intermittent Failures Robot]

25 failures in 4079 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 25

Platform and build breakdown:

• macosx1015-64-qr: 4
  • opt: 4
• windows11-64-2009-qr: 5
  • opt: 5
• linux1804-64-qr: 3
  • opt: 3
• windows11-32-2009-qr: 2
  • opt: 2
• windows11-64-2009-shippable-qr: 4
  • opt: 4
• windows11-32-2009-shippable-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1838778&startday=2023-06-12&endday=2023-06-18&tree=all

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/565e1d49b476
Fix archiveoptions dialog sizing issues. r=john.bieling

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9339771 [details]
Bug 1838778 - Fix archiveoptions dialog sizing issues. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): unclear
User impact if declined: the archiveoptions dialog may have issues
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9339771 [details]
Bug 1838778 - Fix archiveoptions dialog sizing issues. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/9bfee5714156