Open Bug 1838826 Opened 3 years ago Updated 5 months ago

Consider removing the "profiling" talos tasks and use `--gecko-profile` argument in `mach try` to enable profiling

Categories

(Testing :: Talos, task, P3)

Product:
Testing
Component:
Talos
Version:
Default
Type:
task

Tracking

(Not tracked)

People

(Reporter: canova, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxp])

Right now we have separate tasks for talos profiling. But we don't have anything similar in any other test suites, we just use the --gecko-profile argument in mach try. We should ideally remove these tasks and rely on the this flag to enable the profiler.

One thing to keep in mind is that, "talos profiling" tasks do some additional work to make the profiling work, like reducing the cycle count:
https://searchfox.org/mozilla-central/rev/986024d59bff59819a3ed2f7c1d0f5254cdc3f3d/testing/talos/talos/run_tests.py#51-57

We don't do that if user enables the profiler through mach fuzzy. We should have the same behavior to be able to switch.

Whiteboard: [fxp]
Blocks: 1840060
Severity: -- → S3
Priority: -- → P2
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.