1838882 - No "Firefox extension" suggestion displayed after removing the add-on from Add-ons Manager page

Status: NEW

(Firefox :: Address Bar, defect, P5)

Description

[Petruta Horea [:phorea]]

Found in

• Fx 115 beta 6

Affected versions

• Fx 116.0a1, Fx 115 beta 6

Affected platforms

• Ubuntu 22
• Windows 10
• macOS

Preconditions
browser.urlbar.addons.featureGate set to true
browser.urlbar.suggest.addons set to true
browser.urlbar.quicksuggest.enabled set to true
browser.urlbar.suggest.quicksuggest.nonsponsored set to true
browser.urlbar.quicksuggest.dataCollection.enabled set to true
browser.urlbar.merino.enabled set to true
browser.urlbar.merino.providers set to amo
browser.urlbar.bestMatch.enabled set to true

Steps to reproduce

1. Install the following addon.
2. In the URLbar write "clips" "video download" or "entertainment" and make sure that there are no Firefox extension suggestions displayed for Video downloadhelper add-on.
3. Navigate to about:addons -> Extensions section and remove the add-on.
4. In the URLbar write "Video DownloadHelper".

Expected result

• A "Firefox extension" suggestion is displayed for the Video downloadhelper add-on.

Actual result

• The "Firefox extension" suggestion is not displayed until the browser is restarted OR about:addons page is refreshed/closed.

Regression range

• Not a regression

Note
This is not reproducible if the add-on is removed from the AMO installation page (step 1) or using the Extensions icon from toolbar.

Comment 1

[BugBot [:suhaib / :marco]]

:phorea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Drew Willcoxon :adw]

Thanks Petruta, nice catch. This part is key:

The "Firefox extension" suggestion is not displayed until the browser is restarted OR about:addons page is refreshed/closed.

There's an Undo button on about:addons after you remove the extension, so I'm guessing it's not really removed until the page closes, and I bet the AddonManager API exposes this "tentatively removed" state somehow, so we could probably fix this with a one-line change (here).

If you instead remove the addon from the addons button in the toolbar, this bug doesn't happen.

I won't wontfix this since like I say we could probably fix it, but it's very low priority, and it's not in any way a blocker to shipping the feature IMO.