Closed Bug 1838911 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40597 - Revert "View timeline: Handle offscreen stickiness."

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox116 fixed)

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40597 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40597
Details from upstream follow.

Reilly Grant <reillyg@chromium.org> wrote:

Revert "View timeline: Handle offscreen stickiness."

This reverts commit 8164954aefce51cc59f95da80c0acce888a1bc0b.

Reason for revert: Causing flaky failures, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/20525/overview.

Original change's description:

View timeline: Handle offscreen stickiness.

A view timeline subject inside a position:sticky box can get "stuck"
from any of the four CSS offset properties (left, top, right, bottom)
during any of the named view-timeline ranges (entry, contain, exit) or
even while it is entirely outside the viewport.

ViewTimeline::CalculateOffsets previously assumed that stickiness occurred only when the subject was fully contained by the viewport.
This change implements the more general solution.

Bug: 1448294
Change-Id: I842552b3a30078587eff6287e4ee11396d13ed95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616159
Reviewed-by: Kevin Ellis \<kevers@chromium.org>
Commit-Queue: Steve Kobes \<skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158852}

Bug: 1448294
Change-Id: I6d0bcfae16ee2265a2a1a442a646452ea89341e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4621249
WPT-Export-Revision: 4f12affd5d621b02ea751725a34b168dd542a63f

PR 40597 applied with additional changes from upstream: dd6156ef5158cc1538250af5ed20f0909c7bdfce
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88430bfcb8c5 [wpt PR 40597] - Revert "View timeline: Handle offscreen stickiness.", a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/88430bfcb8c5

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.