1838912 - [meta] Break up Toolkit :: Notifications and Alerts into something more manageable

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Toolkit :: Notifications and Alerts has become a bit of a dumping ground for bugs related to... basically any kind of popup or dialog that appears that doesn't have a clear other component. This makes triage challenging, and makes it too easy for important bugs to go unspotted.

I've spoken to Gijs and Mossop about this, and our plan is to try to break up Toolkit :: Notifications and Alerts into several smaller components.

The overall plan is to create the following new components:

• Toolkit: Alerts Service
• Toolkit: PopupNotifications and Notification Bars
• Toolkit: Popup Blocker
• Toolkit: Content Prompts (this would cover things like alert, confirm, prompt, auth prompts)

and also to rename Core :: DOM: Push Notifications to Core :: DOM: Notifications, to allow it to also encompass bugs related to the DOM Notification API (we've discussed this with asuth and jstutte already).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

(I'm not sure whether it's better to re-use the existing Toolkit :: Notifications and Alerts for one of these new components and rename it, or to just empty it out and delete it once we've reorganized the bugs.)

Comment 2

[David Lawrence [:dkl]]

All dependencies closed so maybe this can be closed as well or are there more tasks that need to be done?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I think our next steps are to set some triage rotations on some of these new components. Is it worth keeping this around until then, or just file new bugs once we've got our triagers sorted?

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

I think our next steps are to set some triage rotations on some of these new components. Is it worth keeping this around until then, or just file new bugs once we've got our triagers sorted?

I will happily triage Toolkit: Alerts Service.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Nick Alexander :nalexander [he/him] from comment #4)

I will happily triage Toolkit: Alerts Service.

Outstanding, thanks!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

All dependencies done. Thanks, all!