Closed Bug 1838966 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 40603 - Add the ability to disconnect DOM Parts

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40603 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40603
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Add the ability to disconnect DOM Parts

This turns out to be important, at least in the case of writing
tests. disconnect() is a one-way operation; there's no way to
re-connect a part to its part root.

This CL also adds the constraint that NodePart can't have child parts.
It therefore adds exceptions to the constructors for NodePart and
ChildNodePart in the case that a NodePart is supplied.

Bug: 1453291
Change-Id: Ied398c417b1e105c77a95c3836ee2d09902df7c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617275
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: David Baron \<dbaron@chromium.org>
Commit-Queue: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1159094}

PR 40603 applied with additional changes from upstream: 75e54faea56a60093e172029bb5411f7152af56a, 248252e558f4030ccb34a396b7cfb0c24a8d71d4, 435846e6d26a61feec408588685ca77c5d535024, 0868cb809d40d179379ad406c7da9c07a69429d9
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f59941f32e4 [wpt PR 40603] - Add the ability to disconnect DOM Parts, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.